Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1152723005: Expand patchset if patchsetID provided in URL (Closed)

Created:
5 years, 6 months ago by rmistry
Modified:
5 years, 6 months ago
Reviewers:
jrobbins
CC:
chromium-reviews, rmistry+cc_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Expand patchset if patchsetID provided in URL Context is in the first bug below. BUG=495674 BUG=480453 Staged at https://skia-codereview-staging.appspot.com/1891001/#ps1 Committed: https://chromium.googlesource.com/infra/infra/+/66c9aedb64ec061b7ca097dd056a73c878a84ec0

Patch Set 1 : Initial upload #

Patch Set 2 : Display patchset id #

Total comments: 2

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M appengine/chromium_rietveld/new_static/components/cr-issue-patchsets.html View 1 chunk +9 lines, -1 line 0 comments Download
M appengine/chromium_rietveld/new_static/components/cr-patchset-header.html View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
rmistry
5 years, 6 months ago (2015-06-02 17:42:02 UTC) #2
jrobbins
https://codereview.chromium.org/1152723005/diff/20001/appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html File appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html (right): https://codereview.chromium.org/1152723005/diff/20001/appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html#newcode67 appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html:67: <a class="patchset-id">(Patchset Id: {{ patchset.id }})</a> I realize you ...
5 years, 6 months ago (2015-06-02 19:50:44 UTC) #3
rmistry
https://codereview.chromium.org/1152723005/diff/20001/appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html File appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html (right): https://codereview.chromium.org/1152723005/diff/20001/appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html#newcode67 appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html:67: <a class="patchset-id">(Patchset Id: {{ patchset.id }})</a> On 2015/06/02 19:50:44, ...
5 years, 6 months ago (2015-06-02 20:35:54 UTC) #4
rmistry
On 2015/06/02 20:35:54, rmistry wrote: > https://codereview.chromium.org/1152723005/diff/20001/appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html > File appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html > (right): > > https://codereview.chromium.org/1152723005/diff/20001/appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html#newcode67 ...
5 years, 6 months ago (2015-06-02 23:01:55 UTC) #5
jrobbins
lgtm
5 years, 6 months ago (2015-06-02 23:10:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152723005/40001
5 years, 6 months ago (2015-06-02 23:22:01 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 23:25:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/66c9aedb64ec061b7ca097dd056a7...

Powered by Google App Engine
This is Rietveld 408576698