Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1152703006: Subzero ARM: lowerLoad and lowerStore. (Closed)

Created:
5 years, 6 months ago by jvoung (off chromium)
Modified:
5 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero ARM: lowerLoad and lowerStore. Thought leaving "mov" simple and not handle memory operands, but then we'd have to duplicate some of the lowerAssign code for lowerLoad =/ BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=kschimpf@google.com, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=befd03ab806aebfa9e69087bcfc63210b2b1642a

Patch Set 1 #

Patch Set 2 : leftover format change #

Patch Set 3 : check base is same reg #

Patch Set 4 : rebase #

Patch Set 5 : typo in comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -28 lines) Patch
M src/IceInstARM32.h View 3 chunks +27 lines, -1 line 0 comments Download
M src/IceInstARM32.cpp View 3 chunks +41 lines, -5 lines 0 comments Download
M src/IceTargetLowering.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 2 3 4 3 chunks +45 lines, -5 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringX8632.cpp View 13 chunks +13 lines, -13 lines 0 comments Download
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 1 2 3 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
5 years, 6 months ago (2015-06-01 23:46:10 UTC) #2
Karl
lgtm
5 years, 6 months ago (2015-06-02 17:02:45 UTC) #3
Jim Stichnoth
lgtm
5 years, 6 months ago (2015-06-02 17:08:42 UTC) #4
jvoung (off chromium)
5 years, 6 months ago (2015-06-02 18:03:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
befd03ab806aebfa9e69087bcfc63210b2b1642a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698