Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/tools/android_mojo_shell.py

Issue 1152663002: Makes android.py support gdb (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mandoline/tools/android_run_mandoline.py ('K') | « mandoline/tools/android_run_mandoline.py ('k') | mojo/tools/mopy/android.py » ('j') | mojo/tools/mopy/android.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/android_mojo_shell.py
diff --git a/mojo/tools/android_mojo_shell.py b/mojo/tools/android_mojo_shell.py
index b1bbe000050f172560181cc9a6961df11d473391..c937848c2227118f992315cc08644177459abfa7 100755
--- a/mojo/tools/android_mojo_shell.py
+++ b/mojo/tools/android_mojo_shell.py
@@ -36,7 +36,7 @@ def main():
apk_name="MojoRunner.apk")
paths = Paths(config)
shell = AndroidShell(paths.mojo_runner, paths.build_dir, paths.adb_path,
- launcher_args.target_device)
+ launcher_args.target_device, src_root=paths.src_root)
msw 2015/05/22 02:41:43 nit: not needed, or maybe add the remaining gdb su
sky 2015/05/22 17:27:24 I nuked the src_root from here, as you say it isn'
extra_shell_args = shell.PrepareShellRun(launcher_args.origin)
args.extend(extra_shell_args)
« mandoline/tools/android_run_mandoline.py ('K') | « mandoline/tools/android_run_mandoline.py ('k') | mojo/tools/mopy/android.py » ('j') | mojo/tools/mopy/android.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698