Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: mandoline/tools/android_run_mandoline.py

Issue 1152663002: Makes android.py support gdb (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/tools/android_mojo_shell.py » ('j') | mojo/tools/android_mojo_shell.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mandoline/tools/android_run_mandoline.py
diff --git a/mandoline/tools/android_run_mandoline.py b/mandoline/tools/android_run_mandoline.py
index 9f4274de2ecbfc56c232305d14c1ca13a06997de..c53fd52908e6db5c9d9256a6e1de8c544a540dc4 100755
--- a/mandoline/tools/android_run_mandoline.py
+++ b/mandoline/tools/android_run_mandoline.py
@@ -30,6 +30,11 @@ def main():
parser.add_argument('--target-cpu', help='CPU architecture to run for.',
choices=['x64', 'x86', 'arm'], default='arm')
parser.add_argument('--target-device', help='Device to run on.')
+ parser.add_argument('--dont-install',
msw 2015/05/22 02:41:43 q: just curious, is this needed or just for effici
sky 2015/05/22 17:27:24 For efficiency. If you're doing a bunch of debuggi
msw 2015/05/22 17:52:52 This may not be needed after Jay's CL to install a
+ help='Disables installing the apk',
+ default=False, action='store_true')
+ parser.add_argument('--gdb', help='Run gdb',
+ default=False, action='store_true')
launcher_args, args = parser.parse_known_args()
config = Config(target_os=Config.OS_ANDROID,
@@ -39,14 +44,19 @@ def main():
paths = Paths(config)
shell = AndroidShell(paths.mojo_runner, paths.build_dir, paths.adb_path,
launcher_args.target_device,
- target_package='org.chromium.mandoline')
+ target_package='org.chromium.mandoline',
+ src_root=paths.src_root)
- extra_shell_args = shell.PrepareShellRun()
+ if launcher_args.gdb:
+ shell.PrepareGdb()
+
+ extra_shell_args = shell.PrepareShellRun(
+ install=not launcher_args.dont_install)
args.extend(extra_shell_args)
shell.CleanLogs()
p = shell.ShowLogs()
- shell.StartShell(args, sys.stdout, p.terminate)
+ shell.StartShell(args, sys.stdout, p.terminate, gdb=launcher_args.gdb)
msw 2015/05/22 02:41:43 nit: you don't actually need "gdb=" here
sky 2015/05/22 17:27:24 Done.
return 0
« no previous file with comments | « no previous file | mojo/tools/android_mojo_shell.py » ('j') | mojo/tools/android_mojo_shell.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698