Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1152623006: Limit the behavior of some tests to avoid OS X flake (Closed)

Created:
5 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 6 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M mojo/edk/embedder/platform_channel_pair_posix_unittest.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ken Rockot(use gerrit already)
WDYT?
5 years, 6 months ago (2015-06-01 17:02:09 UTC) #1
viettrungluu
https://codereview.chromium.org/1152623006/diff/1/mojo/edk/system/multiprocess_message_pipe_unittest.cc File mojo/edk/system/multiprocess_message_pipe_unittest.cc (right): https://codereview.chromium.org/1152623006/diff/1/mojo/edk/system/multiprocess_message_pipe_unittest.cc#newcode516 mojo/edk/system/multiprocess_message_pipe_unittest.cc:516: testing::Values(1u, 128u, 140u)); These values would be fine everywhere.
5 years, 6 months ago (2015-06-02 16:41:31 UTC) #2
Ken Rockot(use gerrit already)
https://codereview.chromium.org/1152623006/diff/1/mojo/edk/system/multiprocess_message_pipe_unittest.cc File mojo/edk/system/multiprocess_message_pipe_unittest.cc (right): https://codereview.chromium.org/1152623006/diff/1/mojo/edk/system/multiprocess_message_pipe_unittest.cc#newcode516 mojo/edk/system/multiprocess_message_pipe_unittest.cc:516: testing::Values(1u, 128u, 140u)); On 2015/06/02 16:41:31, viettrungluu wrote: > ...
5 years, 6 months ago (2015-06-02 16:52:33 UTC) #3
viettrungluu
lgtm
5 years, 6 months ago (2015-06-02 16:54:54 UTC) #4
Ken Rockot(use gerrit already)
5 years, 6 months ago (2015-06-02 16:58:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
7341720d0c08ce5a7bc1303cac49299ad47e220d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698