extensions/common/manifest_constants.h - Issue 1152613003: Implement sidebar support for extension action popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_constants.h

Issue 1152613003: Implement sidebar support for extension action popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move SidebarManager to ExtensionSystem and remove notifications Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/manifest_constants.h

diff --git a/extensions/common/manifest_constants.h b/extensions/common/manifest_constants.h

index d5ffa63f30c44de222ec42f5e6263a8c96e1b159..a98c4e965ea59f8fb58752e4556f3fdb36d252dc 100644

--- a/extensions/common/manifest_constants.h

+++ b/extensions/common/manifest_constants.h

@@ -116,6 +116,7 @@ extern const char kPageActionDefaultPopup[];

extern const char kPageActionDefaultTitle[];

extern const char kPageActionIcons[];

extern const char kPageActionId[];

+extern const char kPageActionOpenInSidebar[];

extern const char kPageActionPopup[];

extern const char kPageActionPopupPath[];

extern const char kPermissions[];

« chrome/browser/extensions/sidebar_manager.cc ('K') | « extensions/browser/process_manager.cc ('k') | extensions/common/manifest_constants.cc » ('j') | no next file with comments »