chrome/browser/ui/view_ids.h - Issue 1152613003: Implement sidebar support for extension action popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/view_ids.h

Issue 1152613003: Implement sidebar support for extension action popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move SidebarManager to ExtensionSystem and remove notifications Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/sidebar_manager.cc ('K') | « chrome/browser/ui/extensions/extension_action_view_controller.cc ('k') | chrome/browser/ui/views/frame/browser_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/view_ids.h

diff --git a/chrome/browser/ui/view_ids.h b/chrome/browser/ui/view_ids.h

index e396b9cac71abd286b3be718995b3cb576ca3dbb..055d7731b17d51d0a57aad57aad10b6685b3e739 100644

--- a/chrome/browser/ui/view_ids.h

+++ b/chrome/browser/ui/view_ids.h

@@ -78,9 +78,6 @@ enum ViewID {

// Docked dev tools.

VIEW_ID_DEV_TOOLS_DOCKED,

- // The contents split.

- VIEW_ID_CONTENTS_SPLIT,

// The Infobar container.

VIEW_ID_INFO_BAR_CONTAINER,

@@ -90,6 +87,15 @@ enum ViewID {

// The omnibox icon to do voice-based search.

VIEW_ID_MIC_SEARCH_BUTTON,

+ // The sidebar container.

+ VIEW_ID_SIDE_BAR_CONTAINER,

+ // The sidebar split.

+ VIEW_ID_SIDE_BAR_SPLIT,

+ // The sidebar view.

+ VIEW_ID_SIDE_BAR_VIEW,

// Used in chrome/browser/ui/cocoa/view_id_util_browsertest.mm.

// If you add new ids, make sure the above test passes.

VIEW_ID_PREDEFINED_COUNT,