chrome/browser/ui/cocoa/browser_window_controller_unittest.mm - Issue 1152613003: Implement sidebar support for extension action popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

Issue 1152613003: Implement sidebar support for extension action popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move SidebarManager to ExtensionSystem and remove notifications Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/sidebar_manager.cc ('K') | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/sidebar_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

index 891483f8ad5b3fd12f3682cfb9fbded201cad1f8..459c0ff8232643e811064c7fa6a32542dfa5afb1 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

@@ -57,6 +57,10 @@ using ::testing::Return;

return [findBarCocoaController_ view];

}

+- (NSView*)sidebarView {

+ return [sidebarController_ view];

- (BOOL)bookmarkBarVisible {

return [bookmarkBarController_ isVisible];

}