Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4285)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.h

Issue 1152613003: Implement sidebar support for extension action popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move SidebarManager to ExtensionSystem and remove notifications Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.h
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.h b/chrome/browser/ui/cocoa/browser_window_controller.h
index 1597b0f3fc3106a4c1c63734bd5a0ba68b9f1c41..00ff8824787067aa9e459f5f08eed99e4ad1b302 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.h
+++ b/chrome/browser/ui/cocoa/browser_window_controller.h
@@ -44,6 +44,7 @@ class LocationBarViewMac;
@class OverlayableContentsController;
class PermissionBubbleCocoa;
@class PresentationModeController;
+@class SidebarController;
class StatusBubbleMac;
@class TabStripController;
@class TabStripView;
@@ -87,6 +88,8 @@ class Command;
base::scoped_nsobject<BrowserWindowEnterFullscreenTransition>
enterFullscreenTransition_;
+ base::scoped_nsobject<SidebarController> sidebarController_;
+
// Strong. StatusBubble is a special case of a strong reference that
// we don't wrap in a scoped_ptr because it is acting the same
// as an NSWindowController in that it wraps a window that must
@@ -345,6 +348,10 @@ class Command;
// Shows or hides the docked web inspector depending on |contents|'s state.
- (void)updateDevToolsForContents:(content::WebContents*)contents;
+// Displays the active sidebar linked to the |contents| or hides sidebar UI,
+// if there's no such sidebar.
+- (void)updateSidebarForContents:(content::WebContents*)contents;
+
// Gets the current theme provider.
- (ui::ThemeProvider*)themeProvider;

Powered by Google App Engine
This is Rietveld 408576698