Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1856)

Unified Diff: chrome/browser/extensions/sidebar_container.cc

Issue 1152613003: Implement sidebar support for extension action popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move SidebarManager to ExtensionSystem and remove notifications Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/sidebar_container.cc
diff --git a/chrome/browser/extensions/sidebar_container.cc b/chrome/browser/extensions/sidebar_container.cc
new file mode 100644
index 0000000000000000000000000000000000000000..bf83225e749fb214c96adebcba981a867b13ae6f
--- /dev/null
+++ b/chrome/browser/extensions/sidebar_container.cc
@@ -0,0 +1,73 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/sidebar_container.h"
+
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_view_host_factory.h"
+#include "chrome/browser/extensions/sidebar_manager.h"
+#include "chrome/browser/profiles/profile.h"
+#include "components/app_modal/javascript_dialog_manager.h"
+#include "content/public/browser/notification_details.h"
+#include "content/public/browser/notification_source.h"
+#include "content/public/browser/web_contents.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/extension_resource.h"
+#include "url/gurl.h"
+
+SidebarContainer::SidebarContainer(Browser* browser,
+ content::WebContents* tab,
+ const GURL& url)
+ : host_(extensions::ExtensionViewHostFactory::CreateSidebarHost(url,
+ browser)),
+ host_observer_(this),
+ tab_(tab),
+ navigate_to_default_page_on_expand_(true) {
+ extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(
+ host_contents());
+ host_observer_.Add(host_.get());
+
+ // Listen for the containing view calling window.close();
+ registrar_.Add(
+ this, extensions::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE,
+ content::Source<content::BrowserContext>(host_->browser_context()));
+}
+
+SidebarContainer::~SidebarContainer() {
+}
+
+void SidebarContainer::Show() {
+ host_->CreateRenderViewSoon();
+}
+
+void SidebarContainer::Expand() {
+ if (navigate_to_default_page_on_expand_)
+ navigate_to_default_page_on_expand_ = false;
+
+ host_contents()->SetInitialFocus();
+}
+
+void SidebarContainer::Navigate(const GURL& url) {
+ navigate_to_default_page_on_expand_ = false;
+
+ host_contents()->GetController().LoadURL(
+ url, content::Referrer(), ui::PAGE_TRANSITION_LINK, std::string());
+}
+
+void SidebarContainer::Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) {
+ if (type != extensions::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE) {
+ NOTREACHED() << L"Received unexpected notification";
+ return;
+ }
+
+ // If we aren't the host of the popup, then disregard the notification.
+ if (content::Details<extensions::ExtensionHost>(host_.get()) == details)
+ extensions::SidebarManager::GetFromContext(host_->browser_context())
+ ->HideSidebar(tab_, extension_id());
+}

Powered by Google App Engine
This is Rietveld 408576698