chrome/browser/extensions/extension_view_host.cc - Issue 1152613003: Implement sidebar support for extension action popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_view_host.cc

Issue 1152613003: Implement sidebar support for extension action popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move SidebarManager to ExtensionSystem and remove notifications Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_system_impl.cc ('k') | chrome/browser/extensions/extension_view_host_factory.h » ('j') | chrome/browser/extensions/sidebar_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_view_host.cc

diff --git a/chrome/browser/extensions/extension_view_host.cc b/chrome/browser/extensions/extension_view_host.cc

index 40c48fe316356c14e418b4fa21aaa5d367078d22..347c052ee71d23504d8462668b0ffeadc44b3aa6 100644

--- a/chrome/browser/extensions/extension_view_host.cc

+++ b/chrome/browser/extensions/extension_view_host.cc

@@ -63,7 +63,8 @@ ExtensionViewHost::ExtensionViewHost(

associated_web_contents_(NULL) {

// Not used for panels, see PanelHost.

DCHECK(host_type == VIEW_TYPE_EXTENSION_DIALOG ||

- host_type == VIEW_TYPE_EXTENSION_POPUP);

+ host_type == VIEW_TYPE_EXTENSION_POPUP ||

+ host_type == VIEW_TYPE_EXTENSION_SIDEBAR);

}

ExtensionViewHost::~ExtensionViewHost() {