Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: chrome/browser/extensions/extension_system_impl.h

Issue 1152613003: Implement sidebar support for extension action popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move SidebarManager to ExtensionSystem and remove notifications Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_system_impl.h
diff --git a/chrome/browser/extensions/extension_system_impl.h b/chrome/browser/extensions/extension_system_impl.h
index f4b19c4a5cf92557969e904e2409c72898551d65..54afa3458d25269c6b42d88d712d314e015b7954 100644
--- a/chrome/browser/extensions/extension_system_impl.h
+++ b/chrome/browser/extensions/extension_system_impl.h
@@ -20,6 +20,7 @@ class InstallVerifier;
class NavigationObserver;
class SharedUserScriptMaster;
class StateStoreNotificationObserver;
+// class SidebarManager;
// The ExtensionSystem for ProfileImpl and OffTheRecordProfileImpl.
// Implementation details: non-shared services are owned by
@@ -58,6 +59,9 @@ class ExtensionSystemImpl : public ExtensionSystem {
scoped_ptr<ExtensionSet> GetDependentExtensions(
const Extension* extension) override;
+ SidebarManager* sidebar_manager() override;
+ void CreateSidebarManager();
+
private:
friend class ExtensionSystemSharedFactory;
@@ -128,6 +132,8 @@ class ExtensionSystemImpl : public ExtensionSystem {
Shared* shared_;
+ scoped_refptr<SidebarManager> sidebar_manager_;
+
DISALLOW_COPY_AND_ASSIGN(ExtensionSystemImpl);
};

Powered by Google App Engine
This is Rietveld 408576698