Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc

Issue 1152613003: Implement sidebar support for extension action popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move SidebarManager to ExtensionSystem and remove notifications Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc
diff --git a/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc b/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc
index 9bab6cfabc3f0248937846c0f9fb9e9873cb8768..ccc429ec3be9706bfaf72cbe9239ab3b71635a99 100644
--- a/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc
+++ b/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc
@@ -58,6 +58,9 @@ InspectableViewsFinder::View InspectableViewsFinder::ConstructView(
case VIEW_TYPE_EXTENSION_POPUP:
view->type = api::developer_private::VIEW_TYPE_EXTENSION_POPUP;
break;
+ case VIEW_TYPE_EXTENSION_SIDEBAR:
+ view->type = api::developer_private::VIEW_TYPE_EXTENSION_SIDEBAR;
+ break;
case VIEW_TYPE_LAUNCHER_PAGE:
view->type = api::developer_private::VIEW_TYPE_LAUNCHER_PAGE;
break;
@@ -134,7 +137,8 @@ void InspectableViewsFinder::GetViewsForExtensionProcess(
content::WebContents::FromRenderFrameHost(host);
ViewType host_type = GetViewType(web_contents);
if (host_type == VIEW_TYPE_EXTENSION_POPUP ||
- host_type == VIEW_TYPE_EXTENSION_DIALOG) {
+ host_type == VIEW_TYPE_EXTENSION_DIALOG ||
+ host_type == VIEW_TYPE_EXTENSION_SIDEBAR) {
continue;
}
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_action.h » ('j') | chrome/browser/extensions/sidebar_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698