Implement sidebar support for extension action popups

chrome/browser/ui/cocoa/view_id_util_browsertest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/devtools/devtools_window_testing.h"
 #include "chrome/browser/download/download_shelf.h"
+#include "chrome/browser/extensions/sidebar_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/cocoa/view_id_util.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/view_ids.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "components/bookmarks/browser/bookmark_model.h"
 #include "components/bookmarks/browser/bookmark_utils.h"
 #include "components/bookmarks/test/bookmark_test_helpers.h"
 #include "extensions/common/switches.h"
 
 using bookmarks::BookmarkModel;
 using content::OpenURLParams;
 using content::Referrer;
 
+const char kSimplePage[] = "files/sidebar/simple_page.html";
+
 // Basic sanity check of ViewID use on the mac.
 class ViewIDTest : public InProcessBrowserTest {
  public:
   ViewIDTest() : root_window_(nil) {
     base::CommandLine::ForCurrentProcess()->AppendSwitch(
         extensions::switches::kEnableExperimentalExtensionApis);
   }
 
   void CheckViewID(ViewID view_id, bool should_have) {
     if (!root_window_)
       root_window_ = browser()->window()->GetNativeWindow();
 
     ASSERT_TRUE(root_window_);
     NSView* view = view_id_util::GetView(root_window_, view_id);
     EXPECT_EQ(should_have, !!view) << " Failed id=" << view_id;
   }
 
   void DoTest() {
     // Make sure FindBar is created to test VIEW_ID_FIND_IN_PAGE_TEXT_FIELD.
     chrome::ShowFindBar(browser());
 
+    // Make sure sidebar is created to test VIEW_ID_SIDE_BAR_CONTAINER.
+    const char sidebar_content_id[] = "test_content_id";
+    GURL test_page_url = test_server()->GetURL(kSimplePage);
+    extensions::SidebarManager* sidebar_manager =
+        extensions::SidebarManager::GetFromContext(browser()->profile());
+
+    sidebar_manager->ShowSidebar(
+        static_cast<content::WebContents*>(
+            browser()->tab_strip_model()->GetActiveWebContents()),
+        sidebar_content_id, test_page_url, browser());
+
     // Make sure docked devtools is created to test VIEW_ID_DEV_TOOLS_DOCKED
     DevToolsWindow* devtools_window =
         DevToolsWindowTesting::OpenDevToolsWindowSync(browser(), true);
 
     // Make sure download shelf is created to test VIEW_ID_DOWNLOAD_SHELF
     browser()->window()->GetDownloadShelf()->Show();
 
     // Create a bookmark to test VIEW_ID_BOOKMARK_BAR_ELEMENT
     BookmarkModel* bookmark_model =
         BookmarkModelFactory::GetForProfile(browser()->profile());
     if (bookmark_model) {
       if (!bookmark_model->loaded())
         bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model);
 
       bookmarks::AddIfNotBookmarked(bookmark_model,
                                     GURL(url::kAboutBlankURL),
                                     base::ASCIIToUTF16("about"));
     }
 
     for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) {
       // Mac implementation does not support following ids yet.
-      if (i == VIEW_ID_STAR_BUTTON ||
-          i == VIEW_ID_CONTENTS_SPLIT ||
-          i == VIEW_ID_BROWSER_ACTION ||
-          i == VIEW_ID_FEEDBACK_BUTTON ||
-          i == VIEW_ID_SCRIPT_BUBBLE ||
-          i == VIEW_ID_MIC_SEARCH_BUTTON ||
-          i == VIEW_ID_TRANSLATE_BUTTON) {
+      if (i == VIEW_ID_STAR_BUTTON || i == VIEW_ID_BROWSER_ACTION ||
+          i == VIEW_ID_SIDE_BAR_SPLIT || i == VIEW_ID_SIDE_BAR_VIEW ||
+          i == VIEW_ID_FEEDBACK_BUTTON || i == VIEW_ID_SCRIPT_BUBBLE ||
+          i == VIEW_ID_MIC_SEARCH_BUTTON || i == VIEW_ID_TRANSLATE_BUTTON) {
         continue;
       }
 
       CheckViewID(static_cast<ViewID>(i), true);
     }
 
     CheckViewID(VIEW_ID_TAB, true);
     CheckViewID(VIEW_ID_TAB_STRIP, true);
     CheckViewID(VIEW_ID_PREDEFINED_COUNT, false);
 
@@ skipping 34 matching lines @@
   }
 
   // Open the 11th tab.
   browser()->OpenURL(OpenURLParams(GURL(url::kAboutBlankURL),
                                    Referrer(),
                                    NEW_BACKGROUND_TAB,
                                    ui::PAGE_TRANSITION_TYPED,
                                    false));
   CheckViewID(VIEW_ID_TAB_LAST, true);
 }