chrome/browser/extensions/extension_view_host_factory.cc - Issue 1152613003: Implement sidebar support for extension action popups

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_view_host_factory.cc

Issue 1152613003: Implement sidebar support for extension action popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move SidebarManager to ExtensionSystem and remove notifications Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/extension_view_host_factory.h ('k') | chrome/browser/extensions/sidebar_container.h » ('j') | chrome/browser/extensions/sidebar_manager.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/extension_view_host_factory.h"	5 #include "chrome/browser/extensions/extension_view_host_factory.h"

6	6

7 #include "chrome/browser/extensions/extension_util.h"	7 #include "chrome/browser/extensions/extension_util.h"

8 #include "chrome/browser/extensions/extension_view_host.h"	8 #include "chrome/browser/extensions/extension_view_host.h"

9 #include "chrome/browser/profiles/profile.h"	9 #include "chrome/browser/profiles/profile.h"

10 #include "chrome/browser/ui/browser.h"	10 #include "chrome/browser/ui/browser.h"

(...skipping 95 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
106 }	106 }

107	107

108 // static	108 // static

109 ExtensionViewHost* ExtensionViewHostFactory::CreateDialogHost(	109 ExtensionViewHost* ExtensionViewHostFactory::CreateDialogHost(

110 const GURL& url,	110 const GURL& url,

111 Profile* profile) {	111 Profile* profile) {

112 DCHECK(profile);	112 DCHECK(profile);

113 return CreateViewHost(url, profile, NULL, VIEW_TYPE_EXTENSION_DIALOG);	113 return CreateViewHost(url, profile, NULL, VIEW_TYPE_EXTENSION_DIALOG);

114 }	114 }

115	115

	116 // static

	117 ExtensionViewHost* ExtensionViewHostFactory::CreateSidebarHost(

	118 const GURL& url,

	119 Browser* browser) {

	120 DCHECK(browser);

	121 return CreateViewHost(url, browser->profile(), browser,

	122 VIEW_TYPE_EXTENSION_SIDEBAR);

	123 }

	124

116 } // namespace extensions	125 } // namespace extensions

OLD	NEW