Implement sidebar support for extension action popups

chrome/browser/browser_process.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This interface is for managing the global services of the application. Each
 // service is lazily created when requested the first time. The service getters
 // will return NULL if the service is not available, so callers must check for
 // this condition.
 
 #ifndef CHROME_BROWSER_BROWSER_PROCESS_H_
@@ skipping 18 matching lines @@
 class IOThread;
 class MediaFileSystemRegistry;
 class MetricsServicesManager;
 class NotificationUIManager;
 class PrefRegistrySimple;
 class PrefService;
 class Profile;
 class ProfileManager;
 class PromoResourceService;
 class SafeBrowsingService;
+class SidebarManager;
 class StatusTray;
 class WatchDogThread;
 #if defined(ENABLE_WEBRTC)
 class WebRtcLogUploader;
 #endif
 
 namespace chrome_variations {
 class VariationsService;
 }
 
@@ skipping 64 matching lines @@
 
   // Gets the manager for the various metrics-related services, constructing it
   // if necessary.
   virtual MetricsServicesManager* GetMetricsServicesManager() = 0;
 
   // Services: any of these getters may return NULL
   virtual metrics::MetricsService* metrics_service() = 0;
   virtual rappor::RapporService* rappor_service() = 0;
   virtual ProfileManager* profile_manager() = 0;
   virtual PrefService* local_state() = 0;
+  virtual SidebarManager* sidebar_manager() = 0;

[Devlin, 2015/05/27 16:51:05]

We almost certainly don't want to have a SidebarManager as part of the browser
process (sidebars cannot, for instance, cross profiles).  This should be tied
more closely to a profile, and should probably either be a
BrowserContextKeyedService (or one of its subclasses) or live on the
ExtensionSystem.  My first inclination is probably that the latter makes more
sense.

   virtual net::URLRequestContextGetter* system_request_context() = 0;
   virtual chrome_variations::VariationsService* variations_service() = 0;
   virtual PromoResourceService* promo_resource_service() = 0;
 
   virtual BrowserProcessPlatformPart* platform_part() = 0;
 
   virtual extensions::EventRouterForwarder*
       extension_event_router_forwarder() = 0;
 
   // Returns the manager for desktop notifications.
@@ skipping 106 matching lines @@
 
   virtual gcm::GCMDriver* gcm_driver() = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowserProcess);
 };
 
 extern BrowserProcess* g_browser_process;
 
 #endif  // CHROME_BROWSER_BROWSER_PROCESS_H_