Refactor compile_js.gypi to support script_args and closure_args

third_party/closure_compiler/compile_js.gypi

Index: third_party/closure_compiler/compile_js.gypi
diff --git a/third_party/closure_compiler/compile_js.gypi b/third_party/closure_compiler/compile_js.gypi
index b97b2acffdc65f7ecb72199eeb74dc49124c5d1c..f368d251e7c2cac2cfe020960d593a0d33849f64 100644
--- a/third_party/closure_compiler/compile_js.gypi
+++ b/third_party/closure_compiler/compile_js.gypi
@@ -13,10 +13,46 @@
       # - externs: files that describe globals used by |source|
       'action_name': 'compile_js',
       'variables': {
-        'source_file': '<(_target_name).js',
-        'out_file': '<(SHARED_INTERMEDIATE_DIR)/closure/<!(python <(CLOSURE_DIR)/build/outputs.py <@(source_file))',
+        'source_files': [],
+        'out_file': '<(SHARED_INTERMEDIATE_DIR)/closure/<!(python <(CLOSURE_DIR)/build/outputs.py <@(_target_name).js)',
         'externs%': [],
         'depends%': [],
+        'script_args': [],
+        'closure_args': [
+          '--accept_const_keyword',
+          '--language_in=ECMASCRIPT5_STRICT',
+          '--summary_detail_level=3', # compile.py depends on this for output parsing; do not override.
+          '--compilation_level=SIMPLE_OPTIMIZATIONS',
+          '--source_map_format=V3',
+          '--polymer_pass',
+          "--jscomp_error=accessControls",

[Dan Beam, 2015/06/01 22:57:39]

" -> '

[Theresa, 2015/06/02 22:02:13]

Done.

+          "--jscomp_error=ambiguousFunctionDecl",
+          "--jscomp_error=checkStructDictInheritance",
+          "--jscomp_error=checkTypes",
+          "--jscomp_error=checkVars",
+          "--jscomp_error=constantProperty",
+          "--jscomp_error=deprecated",
+          "--jscomp_error=externsValidation",
+          "--jscomp_error=globalThis",
+          "--jscomp_error=invalidCasts",
+          "--jscomp_error=missingProperties",
+          "--jscomp_error=missingReturn",
+          "--jscomp_error=nonStandardJsDocs",
+          "--jscomp_error=suspiciousCode",
+          "--jscomp_error=undefinedNames",
+          "--jscomp_error=undefinedVars",
+          "--jscomp_error=unknownDefines",
+          "--jscomp_error=uselessCode",
+          "--jscomp_error=visibility",
+          "--extra_annotation_name=attribute",
+          "--extra_annotation_name=status",
+          "--extra_annotation_name=element",
+          "--extra_annotation_name=homepage",
+          "--extra_annotation_name=submodule",
+          "--extra_annotation_name=group",
+          "--jscomp_off=duplicate",
+          "--jscomp_off=misplacedTypeAnnotation",

[Dan Beam, 2015/06/01 22:57:40]

alphabetize this list

[Theresa, 2015/06/02 22:02:12]

Done.

+        ],
       },
       'inputs': [
         'compile_js.gypi',
@@ -34,10 +70,12 @@
       'action': [
         'python',
         '<(CLOSURE_DIR)/compile.py',
-        '<(source_file)',
+        '<(source_files)',

[Dan Beam, 2015/06/01 22:57:39]

where does <(_target_name).js actually get sent to compile.py now?

[Theresa, 2015/06/01 23:46:55]

I decoupled _target_name and source_files, because the .gypi clients in
remoting/ use a target name that does not correspond to an actual source file
name.

In enhanced_bookmarks.gypi, I included get_salient_image_url.js and
dom_initializer.js in the respective source_files lists, so the clients of
closure_compiler/compile_js.gypi would be responsible for including all source
files in said list. The biggest downside to this approach is that it requires
changing all files that include compile_js.gypi, but I am not opposed to doing
that.

Would an alternative be doing something like this in remoting/compile_js.gypi:

'variables': {
 ...
 'source_files!': [<(_target_name).js]
 ...
},

Or do we want to enforce a requirement that the target_name is a source file?

[Dan Beam, 2015/06/02 01:02:33]

  'source_files%': ['<(_target_name.js)'],

https://chromium.googlesource.com/external/gyp/+/master/docs/InputFormatRefer...

+        '<@(script_args)',
         '--depends', '<@(depends)',
         '--externs', '<@(externs)',
         '--out_file', '<(out_file)',
+        '<@(closure_args)',

[Dan Beam, 2015/06/01 22:57:40]

hmmmm, shouldn't this have a -c or --closure(_-)args for it to actually work?

[Theresa, 2015/06/01 23:46:55]

Yes, I think it does.

         # Add '--verbose' for make glorious log spam of Closure compiler.
       ],
       'message': 'Compiling <(source_file)',