Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: remoting/remoting_key_tester.gypi

Issue 1152583011: Refactor compile_js.gypi to support script_args and closure_args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Yet another rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/compile_js.gypi ('k') | remoting/remoting_webapp.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/remoting_key_tester.gypi
diff --git a/remoting/remoting_key_tester.gypi b/remoting/remoting_key_tester.gypi
index 36138a42430a47243bb8ff6ab1d72c76dc52afeb..1ef464239dbde07f9891eee4f886de8442bdcf0c 100644
--- a/remoting/remoting_key_tester.gypi
+++ b/remoting/remoting_key_tester.gypi
@@ -48,27 +48,12 @@
'conditions': [
['run_jscompile != 0', {
'variables': {
- 'success_stamp': '<(PRODUCT_DIR)/<(_target_name).stamp',
+ 'source_files': [
+ '<@(remoting_key_tester_js_files)',
+ ],
+ 'out_file': '<(PRODUCT_DIR)/<(_target_name).stamp',
},
- 'actions': [
- {
- 'action_name': 'jscompile remoting_key_tester',
- 'inputs': [
- '<@(remoting_key_tester_js_files)',
- ],
- 'outputs': [
- '<(success_stamp)',
- ],
- 'action': [
- 'python', '../third_party/closure_compiler/compile.py',
- '--strict',
- '--no-single-file',
- '--externs', '<(DEPTH)/third_party/closure_compiler/externs/chrome_extensions.js',
- '--success-stamp', '<(success_stamp)',
- '<@(remoting_key_tester_js_files)',
- ],
- },
- ], # actions
+ 'includes': ['compile_js.gypi'],
}],
],
}, # end of target 'remoting_key_tester_jscompile'
« no previous file with comments | « remoting/compile_js.gypi ('k') | remoting/remoting_webapp.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698