Refactor compile_js.gypi to support script_args and closure_args

third_party/closure_compiler/compile_js.gypi

Index: third_party/closure_compiler/compile_js.gypi
diff --git a/third_party/closure_compiler/compile_js.gypi b/third_party/closure_compiler/compile_js.gypi
index b97b2acffdc65f7ecb72199eeb74dc49124c5d1c..9b0bffa5bf5b7cc6ebd065612450c24df3927dca 100644
--- a/third_party/closure_compiler/compile_js.gypi
+++ b/third_party/closure_compiler/compile_js.gypi
@@ -13,10 +13,46 @@
       # - externs: files that describe globals used by |source|
       'action_name': 'compile_js',
       'variables': {
-        'source_file': '<(_target_name).js',
+        'source_files': ['<(_target_name).js'],
         'out_file': '<(SHARED_INTERMEDIATE_DIR)/closure/<!(python <(CLOSURE_DIR)/build/outputs.py <@(source_file))',
         'externs%': [],
         'depends%': [],
+        'script_args': [],
+        'closure_args': [
+          '--accept_const_keyword',
+          '--language_in=ECMASCRIPT5_STRICT',
+          '--summary_detail_level=3', # compile.py depends on this for output parsing; do not override.
+          '--compilation_level=SIMPLE_OPTIMIZATIONS',
+          '--source_map_format=V3',
+          '--polymer_pass',
+          "--jscomp_error=accessControls",
+          "--jscomp_error=ambiguousFunctionDecl",
+          "--jscomp_error=checkStructDictInheritance",
+          "--jscomp_error=checkTypes",
+          "--jscomp_error=checkVars",
+          "--jscomp_error=constantProperty",
+          "--jscomp_error=deprecated",
+          "--jscomp_error=externsValidation",
+          "--jscomp_error=globalThis",
+          "--jscomp_error=invalidCasts",
+          "--jscomp_error=missingProperties",
+          "--jscomp_error=missingReturn",
+          "--jscomp_error=nonStandardJsDocs",
+          "--jscomp_error=suspiciousCode",
+          "--jscomp_error=undefinedNames",
+          "--jscomp_error=undefinedVars",
+          "--jscomp_error=unknownDefines",
+          "--jscomp_error=uselessCode",
+          "--jscomp_error=visibility",
+          "--extra_annotation_name=attribute",
+          "--extra_annotation_name=status",
+          "--extra_annotation_name=element",
+          "--extra_annotation_name=homepage",
+          "--extra_annotation_name=submodule",
+          "--extra_annotation_name=group",
+          "--jscomp_off=duplicate",
+          "--jscomp_off=misplacedTypeAnnotation",

[Theresa, 2015/06/01 15:39:26]

I'm not sure if/how compiler flags override each other. If
--jscomp_off=duplicate is added here, but --jscomp_error=duplicate is appended
(either before or after) this set of flags, which one does the compiler respect?

Since the "strict" vs "disabled" closure args contradict each other, I think
they might need to stay in compile.py. Or at least be split out here, in
compile_js.gypi, so their inclusion can be controlled by a variable.

[Dan Beam, 2015/06/01 18:37:47]

we shouldn't send both at once.  we probably also don't need to only use 1
compile_js.gypi for all projects.

if remoting or files.app wants to customize their flags, we can probably can
just make a remoting/compile_js.gypi and mix in options with
third_party/closure_compiler/compile_js.gypi like this:

  # remoting/compile_js.gypi
  {
    'variables': [
      'closure_args!': [
        '--jscomp_off=duplicate',
      ],
      'closure_args': [
        '--jscomp_error=duplicate',
      ],
    ],
    'include': 'compile_js.gypi',
  }

(note that if we don't wanna do 'list_exclusion!', we could make a
compile_js.gypi and compile_js_strict.gypi like iOS does or a couple
per-codebase)

alternatively we could do a one-off for now for strict specifically, but I don't
like that as much

  'strict%': 0,

  'conditions': [
    {'strict == 1': {
      'variables': [
         ... more stricter ...
      ],
    }, { # else strict != 1
      'variables': [
         ... loosening ...
      ],
    }
  ]

+        ],
       },
       'inputs': [
         'compile_js.gypi',
@@ -34,10 +70,12 @@
       'action': [
         'python',
         '<(CLOSURE_DIR)/compile.py',
-        '<(source_file)',
+        '<(source_files)',
+        '<@(script_args)',
         '--depends', '<@(depends)',
         '--externs', '<@(externs)',
         '--out_file', '<(out_file)',
+        '<@(closure_args)',
         # Add '--verbose' for make glorious log spam of Closure compiler.
       ],
       'message': 'Compiling <(source_file)',