Refactor compile_js.gypi to support script_args and closure_args

third_party/closure_compiler/build/inputs.py

Index: third_party/closure_compiler/build/inputs.py
diff --git a/third_party/closure_compiler/build/inputs.py b/third_party/closure_compiler/build/inputs.py
index 9d561462d4772c4fa48ac9594658204568511291..baed2c1b1f235dff4c54907225c60028e194f74d 100755
--- a/third_party/closure_compiler/build/inputs.py
+++ b/third_party/closure_compiler/build/inputs.py
@@ -72,21 +72,25 @@ def resolve_recursive_dependencies(source, input_depends, depends_externs):
 
 def GetInputs(args):
   parser = argparse.ArgumentParser()
-  parser.add_argument("source", nargs=1)
+  parser.add_argument("sources", nargs=argparse.ONE_OR_MORE)
   parser.add_argument("-d", "--depends", nargs=argparse.ZERO_OR_MORE,
                       default=[])
   parser.add_argument("-e", "--externs", nargs=argparse.ZERO_OR_MORE,
                       default=[])
   opts = parser.parse_args(args)
 
-  source = opts.source[0]
-  depends, externs = resolve_recursive_dependencies(
-      source,
-      opts.depends,
-      opts.externs)
+  # TODO(twellington): resolve dependencies for multiple sources.
+  if (len(opts.sources) == 1):

[Dan Beam, 2015/06/16 00:54:43]

nit: no parens

if len(opts.sources) == 1:

[Theresa, 2015/06/16 17:49:45]

Done.

+    depends, externs = resolve_recursive_dependencies(
+        opts.sources[0],
+        opts.depends,
+        opts.externs)
+  else:
+    depends = opts.depends
+    externs = opts.externs
 
   files = set()
-  for file in {source} | set(depends) | externs:
+  for file in set(opts.sources) | set(depends) | set(externs):

[Dan Beam, 2015/06/16 00:54:43]

is doing set() on something that's already a set() cheap?

[Theresa, 2015/06/16 17:49:45]

I don't know that it's cheap - the script fails to run if externs isn't turned
into a set somewhere. I moved the set creation for externs to the else block
above since resolve_recursive_dependencies already makes it a set.

     files.add(file)
     files.update(processor.Processor(file).included_files)