Refactor compile_js.gypi to support script_args and closure_args

third_party/closure_compiler/compile_js.gypi

Index: third_party/closure_compiler/compile_js.gypi
diff --git a/third_party/closure_compiler/compile_js.gypi b/third_party/closure_compiler/compile_js.gypi
index b97b2acffdc65f7ecb72199eeb74dc49124c5d1c..b138a0665b35fa2242de7d5771bed1656dbd201a 100644
--- a/third_party/closure_compiler/compile_js.gypi
+++ b/third_party/closure_compiler/compile_js.gypi
@@ -13,10 +13,19 @@
       # - externs: files that describe globals used by |source|
       'action_name': 'compile_js',
       'variables': {
-        'source_file': '<(_target_name).js',
+        'source_files': ['<(_target_name).js'],
         'out_file': '<(SHARED_INTERMEDIATE_DIR)/closure/<!(python <(CLOSURE_DIR)/build/outputs.py <@(source_file))',
         'externs%': [],
         'depends%': [],
+        'script_args': [],
+        'closure_args': [
+          '--accept_const_keyword',

[Theresa, 2015/05/28 23:12:18]

Would it make more sense to keep these in compile.py and just make this extra
closure_args passed in by client .gypi files. Or should the
polymer_extra_annotations and common_jscomp_errors move here?

[Dan Beam, 2015/05/28 23:15:11]

tbreisacher@ & jlklein@: wdyt?

[Dan Beam, 2015/05/28 23:23:31]

I think we should put them here if possible.  the only thing we might want to
keep inside (or here with a note) is --summary_detail_level=3 which compile.py
depends on for output parsing.

For instance, I'd think we'd change

  'script_args': ['--strict']

to

  'closure_args': [
    '--jscomp_error=reportUnknownTypes',
    '--jscomp_error=duplicate',
    '--jscomp_error=misplacedTypeAnnotation',
  ],

this allows callers to better understand what's going on and not accidentally
have their args overridden in some other place in the code.

+          '--language_in=ECMASCRIPT5_STRICT',
+          '--summary_detail_level=3',
+          '--compilation_level=SIMPLE_OPTIMIZATIONS',
+          '--source_map_format=V3',
+          '--polymer_pass',
+        ],
       },
       'inputs': [
         'compile_js.gypi',
@@ -34,10 +43,12 @@
       'action': [
         'python',
         '<(CLOSURE_DIR)/compile.py',
-        '<(source_file)',
+        '<(source_files)',
+        '<@(script_args)',
         '--depends', '<@(depends)',
         '--externs', '<@(externs)',
         '--out_file', '<(out_file)',
+        '<@(closure_args)',
         # Add '--verbose' for make glorious log spam of Closure compiler.
       ],
       'message': 'Compiling <(source_file)',