Refactor compile_js.gypi to support script_args and closure_args

third_party/closure_compiler/build/inputs.py

Index: third_party/closure_compiler/build/inputs.py
diff --git a/third_party/closure_compiler/build/inputs.py b/third_party/closure_compiler/build/inputs.py
index 9d561462d4772c4fa48ac9594658204568511291..0d9ebbcf871f618d2eca788716aff2643dd0f71b 100755
--- a/third_party/closure_compiler/build/inputs.py
+++ b/third_party/closure_compiler/build/inputs.py
@@ -72,21 +72,21 @@ def resolve_recursive_dependencies(source, input_depends, depends_externs):
 
 def GetInputs(args):
   parser = argparse.ArgumentParser()
-  parser.add_argument("source", nargs=1)
+  parser.add_argument("sources", nargs=argparse.ONE_OR_MORE)
   parser.add_argument("-d", "--depends", nargs=argparse.ZERO_OR_MORE,
                       default=[])
   parser.add_argument("-e", "--externs", nargs=argparse.ZERO_OR_MORE,
                       default=[])
   opts = parser.parse_args(args)
 
-  source = opts.source[0]
+  source = opts.sources[0]

[Dan Beam, 2015/06/08 21:25:45]

shouldn't we be resolving dependencies for all sources?

[Theresa, 2015/06/09 21:21:06]

Since compile.py's check_multiple doesn't even take a depends variable, I don't
think we need to call resolve_recursive_dependencies for multiple sources. Would
it make sense to introduce a --no-single-file arg and do the
resolve_recursive_dependencies call if that flag is not set?

   depends, externs = resolve_recursive_dependencies(
       source,
       opts.depends,
       opts.externs)
 
   files = set()
-  for file in {source} | set(depends) | externs:
+  for file in set(opts.sources) | set(depends) | externs:
     files.add(file)
     files.update(processor.Processor(file).included_files)