Refactor compile_js.gypi to support script_args and closure_args

third_party/closure_compiler/compile_js.gypi

Index: third_party/closure_compiler/compile_js.gypi
diff --git a/third_party/closure_compiler/compile_js.gypi b/third_party/closure_compiler/compile_js.gypi
index b97b2acffdc65f7ecb72199eeb74dc49124c5d1c..dda43c23e316fb31ad2463ed74edd8f081c09e3b 100644
--- a/third_party/closure_compiler/compile_js.gypi
+++ b/third_party/closure_compiler/compile_js.gypi
@@ -17,6 +17,7 @@
         'out_file': '<(SHARED_INTERMEDIATE_DIR)/closure/<!(python <(CLOSURE_DIR)/build/outputs.py <@(source_file))',
         'externs%': [],
         'depends%': [],
+        'extra_args%': [],
       },
       'inputs': [
         'compile_js.gypi',
@@ -35,6 +36,7 @@
         'python',
         '<(CLOSURE_DIR)/compile.py',
         '<(source_file)',
+        '<@(extra_args)',

[Dan Beam, 2015/05/27 00:57:03]

we'd probably want to pass these through to closure directly

[Theresa, 2015/05/28 20:24:22]

One of the things I wanted to use extra args for was --no-single-file, which
controls which method compile.py initially calls into (check or check_multiple).

         '--depends', '<@(depends)',
         '--externs', '<@(externs)',
         '--out_file', '<(out_file)',