Refactor compile_js.gypi to support script_args and closure_args

remoting/remoting_key_tester.gypi

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
     '../build/common_untrusted.gypi',
   ],
 
   'variables': {
@@ skipping 25 matching lines @@
                 'tools/javascript_key_tester/manifest.json',
                 'tools/javascript_key_tester/icon_128.png',
                 'tools/javascript_key_tester/pnacl/remoting_key_tester.nmf',
                 '<(PRODUCT_DIR)/remoting_key_tester_newlib.pexe',
               ],
             }
           ],
         },  # end of target 'remoting_key_tester'
 
         {
           'target_name': 'remoting_key_tester_jscompile',

[Theresa, 2015/06/01 15:39:26]

Do we want to decouple the target_name from the source_file/out_file name? This
current patchset (#3) expects remoting_key_tester_jscompile to be a source file
and the --out_file arg included in script_args below probably causes issues
because compile.py will get two different --out_file args.

           'type': 'none',
           'conditions': [
             ['run_jscompile != 0', {
               'variables': {
                 'success_stamp': '<(PRODUCT_DIR)/<(_target_name).stamp',
+                'source_files': [
+                  '<@(remoting_key_tester_js_files)',
+                  'webapp/js_proto/chrome_proto.js',
+                  'webapp/js_proto/chrome_event_proto.js',
+                ],
+                'script_args' : [
+                  '--no-single-file',
+                  '--success-stamp', '<(success_stamp)',
+                  '--out_file', '<(success_stamp)',
+                ],
+                'closure_args' : [
+                  "--jscomp_error=reportUnknownTypes",
+                  "--jscomp_error=duplicate",
+                  "--jscomp_error=misplacedTypeAnnotation",
+                ]
               },
-              'actions': [
-                {
-                  'action_name': 'jscompile remoting_key_tester',
-                  'inputs': [
-                    '<@(remoting_key_tester_js_files)',
-                    'webapp/js_proto/chrome_proto.js',
-                    'webapp/js_proto/chrome_event_proto.js',
-                  ],
-                  'outputs': [
-                    '<(success_stamp)',
-                  ],
-                  'action': [
-                    'python', '../third_party/closure_compiler/compile.py',
-                    '--strict',
-                    '--no-single-file',
-                    '--success-stamp', '<(success_stamp)',
-                    '<@(remoting_key_tester_js_files)',
-                    'webapp/js_proto/chrome_proto.js',
-                    'webapp/js_proto/chrome_event_proto.js',
-                  ],
-                },
-              ],  # actions
+              'includes': [
+                '../../../third_party/closure_compiler/compile_js.gypi'
+              ],
             }],
           ],
         },  # end of target 'remoting_key_tester_jscompile'
 
         {
           'target_name': 'remoting_key_tester_pexe',
           'type': 'none',
           'sources': [
             'tools/javascript_key_tester/pnacl/remoting_key_tester.cc',
           ],
           'variables': {
             'nexe_target': 'remoting_key_tester',
             'build_glibc': 0,
             'build_newlib': 0,
             'build_pnacl_newlib': 1,
             'extra_deps_pnacl_newlib': [
               '>(tc_lib_dir_pnacl_newlib)/libppapi.a',
               '>(tc_lib_dir_pnacl_newlib)/libppapi_cpp.a',
             ],
           },
           'link_flags': [
             '-lppapi_stub',
             '-lppapi_cpp',
           ],
         },  # end of target 'remoting_key_tester_pexe'
       ],
     }]
   ],
 }