Refactor compile_js.gypi to support script_args and closure_args

third_party/closure_compiler/compile_js.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'type': 'none',
   'variables': {
     'CLOSURE_DIR': '<(DEPTH)/third_party/closure_compiler',
+    'closure_args+': [
+      'accept_const_keyword',
+      'compilation_level=SIMPLE_OPTIMIZATIONS',
+      'extra_annotation_name=attribute',
+      'extra_annotation_name=element',
+      'extra_annotation_name=group',
+      'extra_annotation_name=homepage',
+      'extra_annotation_name=status',
+      'extra_annotation_name=submodule',
+      'jscomp_error=accessControls',
+      'jscomp_error=ambiguousFunctionDecl',
+      'jscomp_error=checkStructDictInheritance',
+      'jscomp_error=checkTypes',
+      'jscomp_error=checkVars',
+      'jscomp_error=constantProperty',
+      'jscomp_error=deprecated',
+      'jscomp_error=externsValidation',
+      'jscomp_error=globalThis',
+      'jscomp_error=invalidCasts',
+      'jscomp_error=missingProperties',
+      'jscomp_error=missingReturn',
+      'jscomp_error=nonStandardJsDocs',
+      'jscomp_error=suspiciousCode',
+      'jscomp_error=undefinedNames',
+      'jscomp_error=undefinedVars',
+      'jscomp_error=unknownDefines',
+      'jscomp_error=uselessCode',
+      'jscomp_error=visibility',
+      'language_in=ECMASCRIPT5_STRICT',
+      'polymer_pass',
+      'source_map_format=V3',
+      'summary_detail_level=3', # compile.py depends on this for output parsing; do not override.
+    ],
   },
   'actions': [
     {
       # This action optionally takes these arguments:
-      # - depends: scripts that the source file depends on being included already
-      # - externs: files that describe globals used by |source|
+      # - source_files: a list of all of the source files to be compiled.
+      #                 If source_files is not defined, |target_name| will be
+      #                 used as the single source file.
+      # - out_file: a file where the compiled output is written to. The default
+      #             is gen/closure/<path to |target_name|>/|target_name|.js.
+      # - depends: scripts that the source file(s) depends on being included already.
+      # - externs: files that describe globals used the source file(s).
+      # - script_args: additional arguments to pass to compile.py.
+      # - closure_args: additional arguments to pass to the Closure compiler.
+      # - closure_strictness_args: additional arguments dealing with the strictness of compilation;
+      #                            Non-strict defaults are provided that can be overriden.
       'action_name': 'compile_js',
       'variables': {
-        'source_file': '<(_target_name).js',
-        'out_file': '<(SHARED_INTERMEDIATE_DIR)/closure/<!(python <(CLOSURE_DIR)/build/outputs.py <@(source_file))',
+        'source_files%': ['<(_target_name).js'],
+        'out_file%': '<(SHARED_INTERMEDIATE_DIR)/closure/<!(python <(CLOSURE_DIR)/build/outputs.py <(_target_name).js)',
         'externs%': [],
         'depends%': [],
+        'script_args%': [],
+        'closure_strictness_args%': [

[Dan Beam, 2015/06/03 23:39:11]

the strictness args are... looser?

[Theresa, 2015/06/04 17:44:05]

I think this could use a better name. The defaults here are looser, with the
intention that other gypi's can override with more strict args.

Maybe it makes more sense to keep the "disabled_closure_args" and
"strict_closure_args" concepts from the current implementation of compile.py.
The set of jscomp_off flags could be the default for disabled_closure_args, and
the default for "strict_closure_args" could be []. gypi's that want more strict
compilation could override disabled_closure_args to be [] and set
strict_closure_args with the flags they want.

Or I could reintroduce a "strict" variable that determines whether
disabled_closure_args or strict_closure_args are included.

[Theresa, 2015/06/04 19:21:30]

I was making this more complexly than necessary. I renamed this variable to
"disabled_closure_args". In remoting/compile_js.gypi, disabled_closure_args is
set to [] and closure_args is extended with the additional jscomp_error flags.

+          'jscomp_off=duplicate',
+          'jscomp_off=misplacedTypeAnnotation',
+        ],
       },
       'inputs': [
         'compile_js.gypi',
         '<(CLOSURE_DIR)/compile.py',
         '<(CLOSURE_DIR)/processor.py',
         '<(CLOSURE_DIR)/build/inputs.py',
         '<(CLOSURE_DIR)/build/outputs.py',
         '<(CLOSURE_DIR)/compiler/compiler.jar',
         '<(CLOSURE_DIR)/runner/runner.jar',
-        '<!@(python <(CLOSURE_DIR)/build/inputs.py <(source_file) -d <@(depends) -e <@(externs))',
+        '<!@(python <(CLOSURE_DIR)/build/inputs.py <@(source_files) -d <@(depends) -e <@(externs))',
       ],
       'outputs': [
         '<(out_file)',
       ],
       'action': [
         'python',
         '<(CLOSURE_DIR)/compile.py',
-        '<(source_file)',
+        '<@(source_files)',
+        '<@(script_args)',
         '--depends', '<@(depends)',
         '--externs', '<@(externs)',
-        '--out_file', '<(out_file)',
+        '--out-file', '<(out_file)',
+        '--closure-args', '<@(closure_args)', '<@(closure_strictness_args)',
         # Add '--verbose' for make glorious log spam of Closure compiler.
       ],
-      'message': 'Compiling <(source_file)',
+      'message': 'Compiling <(_target_name)',
     }
   ],
 }