Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Issue 1152583002: Add constructors to signatures (Closed)

Created:
5 years, 7 months ago by Leaf
Modified:
5 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add constructors to signatures. This adds the types of constructors onto class signatures and makes them available via an exported function in the dart runtime. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/609c371d0923be1f854ddd2d0e325db6146f778f

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+1163 lines, -2 lines) Patch
M lib/runtime/dart/_foreign_helper.js View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/runtime/dart/_interceptors.js View 10 chunks +21 lines, -0 lines 0 comments Download
M lib/runtime/dart/_internal.js View 27 chunks +56 lines, -0 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 13 chunks +27 lines, -0 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 40 chunks +107 lines, -0 lines 0 comments Download
M lib/runtime/dart/_native_typed_data.js View 16 chunks +89 lines, -0 lines 0 comments Download
M lib/runtime/dart/async.js View 68 chunks +139 lines, -0 lines 0 comments Download
M lib/runtime/dart/collection.js View 45 chunks +113 lines, -0 lines 0 comments Download
M lib/runtime/dart/convert.js View 61 chunks +114 lines, -0 lines 0 comments Download
M lib/runtime/dart/core.js View 41 chunks +162 lines, -0 lines 4 comments Download
M lib/runtime/dart/isolate.js View 8 chunks +25 lines, -0 lines 0 comments Download
M lib/runtime/dart/math.js View 7 chunks +19 lines, -0 lines 0 comments Download
M lib/runtime/dart/typed_data.js View 19 chunks +131 lines, -0 lines 0 comments Download
M lib/runtime/dart_runtime.js View 4 chunks +25 lines, -0 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 3 chunks +12 lines, -2 lines 0 comments Download
M test/browser/runtime_tests.js View 2 chunks +23 lines, -0 lines 0 comments Download
M test/codegen/expect/BenchmarkBase.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/codegen/expect/DeltaBlue.js View 10 chunks +12 lines, -0 lines 0 comments Download
M test/codegen/expect/constructors.js View 6 chunks +59 lines, -0 lines 0 comments Download
M test/codegen/expect/misc.js View 1 chunk +3 lines, -0 lines 0 comments Download
M test/codegen/expect/names.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/codegen/expect/sunflower/dom.js View 1 chunk +6 lines, -0 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.js View 2 chunks +6 lines, -0 lines 0 comments Download
M test/codegen/expect/temps.js View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Leaf
5 years, 7 months ago (2015-05-21 20:29:07 UTC) #2
vsm
lgtm but there appears to be an (existing) error on named params https://codereview.chromium.org/1152583002/diff/1/lib/runtime/dart/core.js File lib/runtime/dart/core.js ...
5 years, 7 months ago (2015-05-21 21:21:17 UTC) #3
Leaf
https://codereview.chromium.org/1152583002/diff/1/lib/runtime/dart/core.js File lib/runtime/dart/core.js (right): https://codereview.chromium.org/1152583002/diff/1/lib/runtime/dart/core.js#newcode593 lib/runtime/dart/core.js:593: Duration: [Duration, [], {ay: int, our: int, inute: int, ...
5 years, 7 months ago (2015-05-21 21:35:19 UTC) #4
Leaf
5 years, 7 months ago (2015-05-21 21:49:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
609c371d0923be1f854ddd2d0e325db6146f778f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698