ServiceWorker: Migrate the script cache backend from BlockFile to Simple

content/browser/service_worker/service_worker_database.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_DATABASE_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_DATABASE_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 74 matching lines @@
   };
 
   // Reads next available ids from the database. Returns OK if they are
   // successfully read. Fills the arguments with an initial value and returns
   // OK if they are not found in the database. Otherwise, returns an error.
   Status GetNextAvailableIds(
       int64* next_avail_registration_id,
       int64* next_avail_version_id,
       int64* next_avail_resource_id);
 
+  // Used for diskcache migration (http://crbug.com/487482). Returns true if the
+  // storage needs to migrate a disk cache.
+  Status IsDiskCacheMigrationNeeded(bool* migration_needed);
+  Status SetDiskCacheMigrationNotNeeded();
+
+  // Used for diskcache migration (http://crbug.com/487482). Returns true if the
+  // storage needs to delete an old disk cache.
+  Status IsOldDiskCacheDeletionNeeded(bool* deletion_needed);
+  Status SetOldDiskCacheDeletionNotNeeded();
+
   // Reads origins that have one or more than one registration from the
   // database. Returns OK if they are successfully read or not found.
   // Otherwise, returns an error.
   Status GetOriginsWithRegistrations(std::set<GURL>* origins);
 
   // Reads registrations for |origin| from the database. Returns OK if they are
   // successfully read or not found. Otherwise, returns an error.
   Status GetRegistrationsForOrigin(
       const GURL& origin,
       std::vector<RegistrationData>* registrations,
@@ skipping 254 matching lines @@
   int64 next_avail_resource_id_;
   int64 next_avail_version_id_;
 
   enum State {
     UNINITIALIZED,
     INITIALIZED,
     DISABLED,
   };
   State state_;
 
+#if defined(UNIT_TEST)

[nhiroki, 2015/06/17 02:17:55]

Hmmm... only win_chromium_compile_dbg_ng fails to link this due to "unresolved
external symbol", win_chromium_rel_ng succeeds though. We should unwrap this...?

[nhiroki, 2015/06/17 05:41:06]

This setter needs to be inlined, but the dbg-bot does not do so and then a
linker fails to link. Probably we should also specify !defined(NDEBUG) for the
case like:

https://code.google.com/p/chromium/codesearch#chromium/src/components/visited...

And see the patchset 30.

(yhirano@ kindly helped me investigate, thank you!)


BTW, the presubmit script checks "_for_testing" suffix and shows a warning
message if it's used in non-test files, so we might not have to wrap this with
defined(UNIT_TEST) for such a check. And this could be optimized out in release
build because there is no caller.

+  void set_skip_writing_diskcache_migration_state_on_init_for_testing() {
+    skip_writing_diskcache_migration_state_on_init_for_testing_ = true;
+  }
+#endif
+  bool skip_writing_diskcache_migration_state_on_init_for_testing_;
+
   base::SequenceChecker sequence_checker_;
 
   FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDatabaseTest, OpenDatabase);
   FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDatabaseTest, OpenDatabase_InMemory);
   FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDatabaseTest, DatabaseVersion);
   FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDatabaseTest, GetNextAvailableIds);
   FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDatabaseTest,
                            Registration_UninitializedDatabase);
   FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDatabaseTest,
                            UserData_UninitializedDatabase);
   FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDatabaseTest, DestroyDatabase);
+  FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDatabaseTest, DiskCacheMigrationState);
   FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDatabaseTest, UpgradeSchemaToVersion2);
+  FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDiskCacheMigratorTest,
+                           MigrateOnDiskCacheAccess);
+  FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDiskCacheMigratorTest,
+                           NotMigrateOnDatabaseAccess);
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerDatabase);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_DATABASE_H_