Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 1152533002: Revert of Avoid excessive GCs in small heaps. (Closed)

Created:
5 years, 7 months ago by ulan
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Avoid excessive GCs in small heaps. (patchset #1 id:1 of https://codereview.chromium.org/1144223002/) Reason for revert: Regressed Sunspider. Original issue's description: > Avoid excessive GCs in small heaps. > > Small heaps and small heap growing factor can lead to excessive GCs in corner cases. > > Consider function F(old_gen_size, factor) that returns the number of bytes that > have to be allocated in the old generation to start incremental marking. > > F(4MB, 1.1) = 4MB (because of kMinimumOldGenerationAllocationLimit) > F(6MB, 1.1) = 2MB (because of kMinimumOldGenerationAllocationLimit) > F(8MB, 1.1) = 800KB > > Funtion F should be monotonic in old_gen_size, but it currently has a minimum > at kMinimumOldGenerationAllocationLimit. > > This CL makes F monotonic. > > BUG= > > Committed: https://crrev.com/22b1da99732b4db0754bf267ec470a2831216fb2 > Cr-Commit-Position: refs/heads/master@{#28549} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/e8c593c4f826480861f973b59cc596fb7a88f2d8 Cr-Commit-Position: refs/heads/master@{#28558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
Created Revert of Avoid excessive GCs in small heaps.
5 years, 7 months ago (2015-05-21 14:46:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152533002/1
5 years, 7 months ago (2015-05-21 14:47:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 14:47:30 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 14:47:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8c593c4f826480861f973b59cc596fb7a88f2d8
Cr-Commit-Position: refs/heads/master@{#28558}

Powered by Google App Engine
This is Rietveld 408576698