Issue 115253004: [Android WebView] Prepare to remove AwSettings.LayoutAlgorithm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115253004: [Android WebView] Prepare to remove AwSettings.LayoutAlgorithm (Closed)

Created:
6 years, 11 months ago by mnaganov (inactive)

Modified:
6 years, 11 months ago

Reviewers:
benm (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android WebView] Prepare to remove AwSettings.LayoutAlgorithm Usages of AwSettings.LayoutAlgorithm need to be replaced with WebSettings.LayoutAlgorithm. This change also fixes a couple of trivial presubmit warnings in existing code. BUG=332089 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243576

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -9 lines)			Patch
	M	android_webview/java/src/org/chromium/android_webview/AwSettings.java	View		7 chunks	+22 lines, -7 lines	0 comments	Download
	M	android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/115253004/1

6 years, 11 months ago (2014-01-08 13:42:42 UTC) #4

Noam Samuel

6 years, 11 months ago (2014-01-08 18:33:48 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/128933002/ by noamsml@chromium.org.

The reason for reverting is: http://crbug.com/332434.

Expand Messages | Collapse Messages