Issue 115253002: [Files.app] Fix a potential error in ShareDialog/FileManagerBrowserTest

Issue 115253002: [Files.app] Fix a potential error in ShareDialog/FileManagerBrowserTest (Closed)

Created:
7 years ago by yoshiki

Modified:
7 years ago

Reviewers:
mtomasz

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Files.app] Fix a potential issue in ShareDialog/FileManagerBrowserTest In the share dialog mock, the wrong function was called and this patch fixes it. Currently that didn't cause a test failure because the 'waitElement' has some bug as well . And this patch added some assertion into the test for reliability. BUG=328762 TEST=manually R=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241146

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
M	chrome/test/data/chromeos/file_manager/share_dialog_mock/index.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/chromeos/file_manager/share_dialog_mock/main.js	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

mtomasz

Thanks for fixing it! LGTM with 2 nit. https://codereview.chromium.org/115253002/diff/1/chrome/test/data/chromeos/file_manager/share_dialog_mock/main.js File chrome/test/data/chromeos/file_manager/share_dialog_mock/main.js (right): https://codereview.chromium.org/115253002/diff/1/chrome/test/data/chromeos/file_manager/share_dialog_mock/main.js#newcode95 chrome/test/data/chromeos/file_manager/share_dialog_mock/main.js:95: /** ...

7 years ago (2013-12-16 03:58:31 UTC) #2

yoshiki

Thanks! https://codereview.chromium.org/115253002/diff/1/chrome/test/data/chromeos/file_manager/share_dialog_mock/main.js File chrome/test/data/chromeos/file_manager/share_dialog_mock/main.js (right): https://codereview.chromium.org/115253002/diff/1/chrome/test/data/chromeos/file_manager/share_dialog_mock/main.js#newcode95 chrome/test/data/chromeos/file_manager/share_dialog_mock/main.js:95: /** On 2013/12/16 03:58:31, mtomasz wrote: > > ...

7 years ago (2013-12-16 04:29:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/115253002/20001

7 years ago (2013-12-16 04:29:24 UTC) #4

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=202838

7 years ago (2013-12-16 05:23:35 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/115253002/20001

7 years ago (2013-12-16 18:08:00 UTC) #6

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204982

7 years ago (2013-12-16 19:30:38 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r241146 (presubmit successful).

Expand Messages | Collapse Messages