Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1152513002: Generalize alignment in heap GC functions. (Closed)

Created:
5 years, 7 months ago by bbudge
Modified:
5 years, 7 months ago
CC:
v8-dev, Yang, Benedikt Meurer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Generalize alignment in heap GC functions. Changes template parameters from int to AllocationAlignment. LOG=N BUG=v8:4124 Committed: https://crrev.com/871ab7f7b1847bdb78773b8abfec2b65c2b1faa8 Cr-Commit-Position: refs/heads/master@{#28587}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Review comments. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -29 lines) Patch
M src/heap/heap.cc View 1 2 9 chunks +19 lines, -29 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
bbudge
5 years, 7 months ago (2015-05-21 12:28:20 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1152513002/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1152513002/diff/20001/src/heap/heap.cc#newcode2257 src/heap/heap.cc:2257: #define kObjectAligned kDoubleAligned Why do we need this? https://codereview.chromium.org/1152513002/diff/20001/src/heap/heap.cc#newcode2265 ...
5 years, 7 months ago (2015-05-22 06:11:13 UTC) #4
bbudge
https://codereview.chromium.org/1152513002/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1152513002/diff/20001/src/heap/heap.cc#newcode2257 src/heap/heap.cc:2257: #define kObjectAligned kDoubleAligned On 2015/05/22 06:11:12, Hannes Payer wrote: ...
5 years, 7 months ago (2015-05-22 07:34:33 UTC) #5
Hannes Payer (out of office)
Cool, thx. LGTM
5 years, 7 months ago (2015-05-22 10:50:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152513002/60001
5 years, 7 months ago (2015-05-22 11:22:30 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 7 months ago (2015-05-22 12:02:08 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 12:02:16 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/871ab7f7b1847bdb78773b8abfec2b65c2b1faa8
Cr-Commit-Position: refs/heads/master@{#28587}

Powered by Google App Engine
This is Rietveld 408576698