Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1152503002: [destructuring] Implement pattern matching in lexcal for-of/for-in. (Closed)

Created:
5 years, 7 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[destructuring] Implement pattern matching in lexcal for-of/for-in. R=arv@chromium.org,rossberg@chromium.org BUG=v8:811 LOG=N Committed: https://crrev.com/8925b848eeb9ef996d36e23fedcaee80d02c14f5 Cr-Commit-Position: refs/heads/master@{#28547}

Patch Set 1 #

Patch Set 2 : Add tests for for-in #

Patch Set 3 : Remove commented-out code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -14 lines) Patch
M src/parser.cc View 1 2 3 chunks +16 lines, -14 lines 0 comments Download
M test/mjsunit/harmony/destructuring.js View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Dmitry Lomov (no reviews)
PTAL. Turned out to be easy enough after my ParseVariableDeclarations refactoring.
5 years, 7 months ago (2015-05-21 11:17:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152503002/20001
5 years, 7 months ago (2015-05-21 11:24:34 UTC) #3
rossberg
lgtm
5 years, 7 months ago (2015-05-21 12:09:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152503002/40001
5 years, 7 months ago (2015-05-21 12:11:05 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-21 12:36:19 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/8925b848eeb9ef996d36e23fedcaee80d02c14f5 Cr-Commit-Position: refs/heads/master@{#28547}
5 years, 7 months ago (2015-05-21 12:36:33 UTC) #8
arv (Not doing code reviews)
5 years, 7 months ago (2015-05-21 12:44:06 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698