Issue 1152483006: Make tracing work in the new .dart world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1152483006: Make tracing work in the new .dart world. (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
viktorl, abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make tracing work in the new .dart world. R=abarth@chromium.org, viktorl@google.com Committed: https://chromium.googlesource.com/external/mojo/+/451690077f95d775b168a4436bb408b3b99722b5

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -1 line)			Patch
M	sky/engine/bindings/scripts/templates/dart_blink.template	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/frame/Tracing.idl	View	1 chunk	+3 lines, -1 line	1 comment	Download
M	sky/examples/raw/spinning_square.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/1152483006/diff/1/sky/engine/core/frame/Tracing.idl File sky/engine/core/frame/Tracing.idl (right): https://codereview.chromium.org/1152483006/diff/1/sky/engine/core/frame/Tracing.idl#newcode7 sky/engine/core/frame/Tracing.idl:7: ]interface Tracing { ]interface => ] interface

5 years, 6 months ago (2015-06-03 19:40:10 UTC) #2

eseidel

5 years, 6 months ago (2015-06-03 19:40:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
451690077f95d775b168a4436bb408b3b99722b5 (presubmit successful).

Expand Messages | Collapse Messages