Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Unified Diff: cc/layers/tiled_layer_impl_unittest.cc

Issue 1152473006: cc: Remove DrawQuad::IterateResoruces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/tiled_layer_impl_unittest.cc
diff --git a/cc/layers/tiled_layer_impl_unittest.cc b/cc/layers/tiled_layer_impl_unittest.cc
index 79ecfa3e31bd3903e2d99a05f075b0ae7e0209f9..7ef93f66e515b9ab12c5cd1b2c0fa98588c70c4d 100644
--- a/cc/layers/tiled_layer_impl_unittest.cc
+++ b/cc/layers/tiled_layer_impl_unittest.cc
@@ -269,8 +269,8 @@ TEST_F(TiledLayerImplTest, TextureInfoForLayerNoBorders) {
++iter) {
const TileDrawQuad* quad = TileDrawQuad::MaterialCast(*iter);
- EXPECT_NE(0u, quad->resource_id) << LayerTestCommon::quad_string
- << iter.index();
+ EXPECT_NE(0u, quad->resource_id()) << LayerTestCommon::quad_string
danakj 2015/05/28 17:10:05 You could check resources.count == 1 and resources
vmpstr 2015/05/28 18:38:45 I kind of prefer having this type of accessor... I
danakj 2015/05/28 19:02:29 What if each DrawQuad subclass had a public kNumRe
vmpstr 2015/05/28 19:18:50 It's not really a constant (it's determined when S
+ << iter.index();
EXPECT_EQ(gfx::RectF(gfx::PointF(), tile_size), quad->tex_coord_rect)
<< LayerTestCommon::quad_string << iter.index();
EXPECT_EQ(tile_size, quad->texture_size) << LayerTestCommon::quad_string

Powered by Google App Engine
This is Rietveld 408576698