Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: cc/layers/delegated_renderer_layer_impl.cc

Issue 1152473006: cc: Remove DrawQuad::IterateResoruces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/layer_impl.h » ('j') | cc/layers/layer_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/delegated_renderer_layer_impl.cc
diff --git a/cc/layers/delegated_renderer_layer_impl.cc b/cc/layers/delegated_renderer_layer_impl.cc
index 5b6bc6cc3fff7c9cf45bab30afddc738919dc47e..3d5e6ddbdf2af19b48c4582d86badeefa42478bc 100644
--- a/cc/layers/delegated_renderer_layer_impl.cc
+++ b/cc/layers/delegated_renderer_layer_impl.cc
@@ -134,14 +134,14 @@ void DelegatedRendererLayerImpl::SetFrameData(
if (reserve_size)
resources_in_frame.resize(reserve_size);
#endif
- DrawQuad::ResourceIteratorCallback remap_resources_to_parent_callback =
- base::Bind(&ResourceRemapHelper,
- &invalid_frame,
- resource_map,
- &resources_in_frame);
for (const auto& pass : render_pass_list) {
for (const auto& quad : pass->quad_list)
danakj 2015/05/28 17:10:05 {}
vmpstr 2015/05/28 18:38:45 Done.
- quad->IterateResources(remap_resources_to_parent_callback);
+ quad->IterateResources(
danakj 2015/05/28 17:10:05 Does this look nicer/worse with just walking thru
piman 2015/05/28 18:37:59 Actually... I think we may be able to do something
vmpstr 2015/05/28 18:38:45 Yep, that does look better. In the current version
+ [&invalid_frame, &resource_map, &resources_in_frame](
+ ResourceId resource_id) {
+ return ResourceRemapHelper(&invalid_frame, resource_map,
danakj 2015/05/28 17:10:05 I *think* I'd just put the body of this helper her
vmpstr 2015/05/28 18:38:45 Yeah, I could, but I prefer keeping lambdas very s
+ &resources_in_frame, resource_id);
+ });
}
if (invalid_frame) {
« no previous file with comments | « no previous file | cc/layers/layer_impl.h » ('j') | cc/layers/layer_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698