Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: cc/quads/draw_quad_perftest.cc

Issue 1152473006: cc: Remove DrawQuad::IterateResoruces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mkwst review Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/quads/draw_quad_perftest.cc
diff --git a/cc/quads/draw_quad_perftest.cc b/cc/quads/draw_quad_perftest.cc
index 459d4eaf9f03a626a01596d24e42e03f77a37eb3..0473238e9d5af1e2ef9b60b284a7a6ec43fa6ca5 100644
--- a/cc/quads/draw_quad_perftest.cc
+++ b/cc/quads/draw_quad_perftest.cc
@@ -20,10 +20,6 @@ static const int kTimeLimitMillis = 2000;
static const int kWarmupRuns = 5;
static const int kTimeCheckInterval = 10;
-ResourceId Increment(ResourceId resource_id) {
- return resource_id + 1;
-}
-
SharedQuadState* CreateSharedQuadState(RenderPass* render_pass) {
gfx::Transform quad_transform = gfx::Transform(1.0, 0.0, 0.5, 1.0, 0.5, 0.0);
gfx::Size content_bounds(26, 28);
@@ -88,10 +84,11 @@ class DrawQuadPerfTest : public testing::Test {
GenerateTextureDrawQuads(quad_count, &quads);
timer_.Reset();
- DrawQuad::ResourceIteratorCallback callback = base::Bind(&Increment);
do {
- for (auto* quad : quads)
- quad->IterateResources(callback);
+ for (auto* quad : quads) {
+ for (ResourceId& resource_id : quad->resources)
+ ++resource_id;
+ }
timer_.NextLap();
} while (!timer_.HasTimeLimitExpired());

Powered by Google App Engine
This is Rietveld 408576698