Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: ui/events/gesture_detection/motion_event.h

Issue 1152463004: Fix motion event orientation handling for styluses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/events/blink/blink_event_util.cc ('K') | « ui/events/blink/blink_event_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/gesture_detection/motion_event.h
diff --git a/ui/events/gesture_detection/motion_event.h b/ui/events/gesture_detection/motion_event.h
index a6028fbdee52c3feb6394960f08ae0b563119270..685622c0c2511cebfbcc42937f680b06a2882fc9 100644
--- a/ui/events/gesture_detection/motion_event.h
+++ b/ui/events/gesture_detection/motion_event.h
@@ -93,7 +93,8 @@ class GESTURE_DETECTION_EXPORT MotionEvent {
float GetTouchMinor() const { return GetTouchMinor(0); }
// Returns the orientation of the major axis clockwise from vertical, in
Rick Byers 2015/05/26 20:21:33 For stylus this isn't really returning "the orient
USE eero AT chromium.org 2015/05/27 08:39:39 Done.
- // radians. The return value lies in [-PI/2, PI/2].
+ // radians. The return value lies in [-PI, PI] (for a stylus) or in
+ // [-PI/2, PI/2] (for a touch screen or pad).
float GetOrientation() const { return GetOrientation(0); }
float GetPressure() const { return GetPressure(0); }
« ui/events/blink/blink_event_util.cc ('K') | « ui/events/blink/blink_event_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698