Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(54)

Issue 1152413003: General code cleanup of ChromeClient-related classes. (Closed)

Created:
4 years, 11 months ago by tkent
Modified:
4 years, 11 months ago
CC:
blink-reviews, tyoshino+watch_chromium.org, krit, rwlbuis, fs, kouhei+svg_chromium.org, f(malita), gavinp+loader_chromium.org, gyuyoung2, Stephen Chennney, Nate Chapin, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

General code cleanup of ChromeClient-related classes. - Code simplification - Remove |virtual| of |override| functions - Remove unnecessary includes and class declarations - Use nullptr instead of 0 - Use range-based |for| - etc. This CL has no behavior changes. BUG=495378 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196387

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -261 lines) Patch
M Source/core/loader/EmptyClients.h View 1 chunk +58 lines, -59 lines 0 comments Download
M Source/core/page/ChromeClient.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/ChromeClient.cpp View 4 chunks +12 lines, -9 lines 0 comments Download
M Source/core/svg/graphics/SVGImageChromeClient.h View 1 chunk +4 lines, -4 lines 2 comments Download
M Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.h View 2 chunks +93 lines, -109 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 13 chunks +42 lines, -54 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 5 chunks +20 lines, -21 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
tkent
yosin@, please review this.
4 years, 11 months ago (2015-06-03 06:36:56 UTC) #2
kouhei (in TOK)
lgtm
4 years, 11 months ago (2015-06-03 06:38:03 UTC) #4
yosin_UTC9
lgtm https://codereview.chromium.org/1152413003/diff/1/Source/core/svg/graphics/SVGImageChromeClient.h File Source/core/svg/graphics/SVGImageChromeClient.h (right): https://codereview.chromium.org/1152413003/diff/1/Source/core/svg/graphics/SVGImageChromeClient.h#newcode43 Source/core/svg/graphics/SVGImageChromeClient.h:43: bool isSVGImageChromeClient() const override; Q: Do you recommend ...
4 years, 11 months ago (2015-06-03 07:15:27 UTC) #6
tkent
https://codereview.chromium.org/1152413003/diff/1/Source/core/svg/graphics/SVGImageChromeClient.h File Source/core/svg/graphics/SVGImageChromeClient.h (right): https://codereview.chromium.org/1152413003/diff/1/Source/core/svg/graphics/SVGImageChromeClient.h#newcode43 Source/core/svg/graphics/SVGImageChromeClient.h:43: bool isSVGImageChromeClient() const override; On 2015/06/03 07:15:27, Yosi_UTC9 wrote: ...
4 years, 11 months ago (2015-06-03 07:22:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152413003/1
4 years, 11 months ago (2015-06-03 08:07:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64663)
4 years, 11 months ago (2015-06-03 09:08:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152413003/1
4 years, 11 months ago (2015-06-03 09:09:21 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 10:08:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196387

Powered by Google App Engine
This is Rietveld 408576698