Source/modules/bluetooth/BluetoothGATTRemoteServer.h - Issue 1152393002: bluetooth: Blink side implementation of getPrimaryService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/bluetooth/BluetoothGATTRemoteServer.h

Issue 1152393002: bluetooth: Blink side implementation of getPrimaryService (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@bluetooth-get-primary-service-interface

Patch Set: Fixed layout test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/bluetooth/getPrimaryService.html ('K') | « LayoutTests/bluetooth/getPrimaryService.html ('k') | Source/modules/bluetooth/BluetoothGATTRemoteServer.cpp » ('j') | Source/modules/bluetooth/BluetoothGATTRemoteServer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/bluetooth/BluetoothGATTRemoteServer.h

diff --git a/Source/modules/bluetooth/BluetoothGATTRemoteServer.h b/Source/modules/bluetooth/BluetoothGATTRemoteServer.h

index 75e865c6b55e779b82d20d167ad7ea653d9ae554..a6ceae25123e6b4151d48e3091ebbf7ad33a3ec5 100644

--- a/Source/modules/bluetooth/BluetoothGATTRemoteServer.h

+++ b/Source/modules/bluetooth/BluetoothGATTRemoteServer.h

@@ -8,10 +8,13 @@

#include "bindings/core/v8/ScriptWrappable.h"

#include "platform/heap/Heap.h"

#include "public/platform/modules/bluetooth/WebBluetoothGATTRemoteServer.h"

+#include "wtf/text/WTFString.h"

namespace blink {

+class ScriptPromise;

class ScriptPromiseResolver;

+class ScriptState;

// BluetoothGATTRemoteServer provides a way to interact with a connected bluetooth peripheral.

@@ -36,6 +39,7 @@ public:

// IDL exposed interface:

bool connected() { return m_webGATT.connected; }

+ ScriptPromise getPrimaryService(ScriptState*, String /* service_uuid */);

scheib 2015/05/29 00:17:32 Use parameter name, not comment.

ortuno 2015/06/01 21:21:34 Done.

private:

WebBluetoothGATTRemoteServer m_webGATT;