LayoutTests/bluetooth/getPrimaryService.html - Issue 1152393002: bluetooth: Blink side implementation of getPrimaryService

Side by Side Diff: LayoutTests/bluetooth/getPrimaryService.html

Issue 1152393002: bluetooth: Blink side implementation of getPrimaryService (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@bluetooth-get-primary-service-interface

Patch Set: Test cleanup Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script src="bluetooth-helpers.js"></script>

	5 <script>

	6 test(function(t) { assert_exists(window, "testRunner"); t.done(); },

	7 "window.testRunner is required for the following tests.");

	8

	9 var generic_access = "00001800-0000-1000-8000-00805f9b34fb";

	10 var heart_rate = "0000180D-0000-1000-8000-00805f9b34fb";

	11

	12 sequential_promise_test(function() {

	13 testRunner.setBluetoothMockDataSet('ConnectableDeviceAdapter');

	14 return navigator.bluetooth.requestDevice().then(function(device) {

	15 return device.connectGATT().then(function(gattServer) {
	Jeffrey Yasskin 2015/06/02 20:28:07 I think you can collapse this to: return navigato I think you can collapse this to: return navigator.bluetooth.requestDevice().then(function(device) { return device.connectGATT(); }).then(function(gattServer) { testRunner.setBluetoothMockDataSet('EmptyAdapter'); return gattServer.getPrimaryService(generic_access).then(function() { assert_unreached('Should return error if device not in adapter.'); }, function(e) { assert_equals(e.name, "NetworkError"); }); }); ortuno 2015/06/03 03:05:16 Done. Show quoted text On 2015/06/02 20:28:07, Jeffrey Yasskin wrote: > I think you can collapse this to: > > return navigator.bluetooth.requestDevice().then(function(device) { > return device.connectGATT(); > }).then(function(gattServer) { > testRunner.setBluetoothMockDataSet('EmptyAdapter'); > return gattServer.getPrimaryService(generic_access).then(function() { > assert_unreached('Should return error if device not in adapter.'); > }, function(e) { > assert_equals(e.name, "NetworkError"); > }); > }); Done.
	16 testRunner.setBluetoothMockDataSet('EmptyAdapter');

	17 return gattServer.getPrimaryService(generic_access).then(function() {

	18 assert_unreached('Should return error if device not in adapter.');

	19 }, function(e) {

	20 assert_equals(e.name, "NetworkError");

	21 });

	22 });

	23 });

	24 }, 'Device goes out of range. Reject with NetworkError.');

	25

	26 sequential_promise_test(function() {

	27 testRunner.setBluetoothMockDataSet('ConnectableDeviceAdapter');

	28 return navigator.bluetooth.requestDevice().then(function(device) {

	29 return device.connectGATT();

	30 }).then(function(gattServer) {

	31 return gattServer.getPrimaryService(heart_rate);

	32 }).then(function(service) {

	33 assert_equals(service, null,

	34 "Non existent services should return null.");

	35 });

	36 }, 'Request for wrong service. Should return null.');

	37

	38 sequential_promise_test(function() {

	39 testRunner.setBluetoothMockDataSet('ConnectableDeviceAdapter');

	40 return navigator.bluetooth.requestDevice().then(function(device) {

	41 return device.connectGATT();

	42 }).then(function(gattServer) {

	43 return gattServer.getPrimaryService(generic_access);

	44 }).then(function(service) {

	45 assert_equals(service.uuid, generic_access,

	46 "Service UUID should be the same as requested UUID.");

	47 assert_true(service.isPrimary,

	48 "getPrimaryService should return a primary service.");

	49 });

	50 }, 'Request for service. Should return right service');

	51

	52 sequential_promise_test(function() {

	53 testRunner.setBluetoothMockDataSet('ConnectableDeviceAdapter');

	54 return navigator.bluetooth.requestDevice().then(function(device) {

	55 return device.connectGATT();

	56 }).then(function(gattServer) {

	57 return Promise.all([gattServer.getPrimaryService(generic_access),

	58 gattServer.getPrimaryService(generic_access)]);

	59 }).then(function(services) {

	60 // TODO(ortuno): getPrimaryService should return the same object

	61 // if it was created earlier.

	62 // https://crbug.com/495270

	63 assert_not_equals(services[0], services[1],
	Jeffrey Yasskin 2015/06/02 20:28:07 Maybe be clearer that this assertion is going to c Maybe be clearer that this assertion is going to change senses. There's also another aspect of this that we should test: if you add a property to the first service you get, then let it go out of scope and be garbage collected, and then retrieve the same service again and look at that property, the thing you assigned should still be there. ortuno 2015/06/03 03:05:16 Done. Show quoted text On 2015/06/02 20:28:07, Jeffrey Yasskin wrote: > Maybe be clearer that this assertion is going to change senses. Done. Show quoted text > There's also another aspect of this that we should test: if you add a property > to the first service you get, then let it go out of scope and be garbage > collected, and then retrieve the same service again and look at that property, > the thing you assigned should still be there. Ok. Need to think about how to implement that. Jeffrey Yasskin 2015/06/03 15:10:04 Ask esprehn or another DOM expert when you get aro Show quoted text On 2015/06/03 03:05:16, ortuno wrote: > On 2015/06/02 20:28:07, Jeffrey Yasskin wrote: > > There's also another aspect of this that we should test: if you add a property > > to the first service you get, then let it go out of scope and be garbage > > collected, and then retrieve the same service again and look at that property, > > the thing you assigned should still be there. > > Ok. Need to think about how to implement that. Ask esprehn or another DOM expert when you get around to it. Apparently there's a known technique. ortuno 2015/06/03 17:02:18 Will do. Show quoted text On 2015/06/03 at 15:10:04, Jeffrey Yasskin wrote: > On 2015/06/03 03:05:16, ortuno wrote: > > On 2015/06/02 20:28:07, Jeffrey Yasskin wrote: > > > There's also another aspect of this that we should test: if you add a property > > > to the first service you get, then let it go out of scope and be garbage > > > collected, and then retrieve the same service again and look at that property, > > > the thing you assigned should still be there. > > > > Ok. Need to think about how to implement that. > > Ask esprehn or another DOM expert when you get around to it. Apparently there's a known technique. Will do.
	64 "Should return the same service as the first call.");

	65 });

	66 }, 'Calls to get the same service should return the same object.');

	67

	68 </script>

OLD	NEW

« no previous file with comments | « no previous file | Source/modules/bluetooth/BluetoothGATTRemoteServer.h » ('j') | Source/modules/bluetooth/BluetoothGATTRemoteServer.cpp » ('J')