Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1152373003: url: Fix the TODO in url_parse.h header. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, dbeam+watch-options_chromium.org, davidben+watch_chromium.org, cbentzel+watch_chromium.org, michaelpg+watch-options_chromium.org, chromoting-reviews_chromium.org, tburkard+watch_chromium.org, vabr+watchlist_chromium.org, gavinp+prer_chromium.org, oshima+watch_chromium.org, gcasto+watchlist_chromium.org, James Su, stevenjb+watch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

url: Fix the TODO in url_parse.h header. this removes url/url_parse.h header, since it was just a pass through for url/third_party/mozilla/url_parse.h, and update the call sites. BUG=None R=brettw@chromium.org Committed: https://crrev.com/018de6ec894a3d4015ca61e2c46dedaf24b1fff5 Cr-Commit-Position: refs/heads/master@{#331390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -46 lines) Patch
M chrome/browser/autocomplete/history_quick_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/url_parse_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/autocomplete_input.h View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/autocomplete_input_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/affiliation_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/browser/url_blacklist_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/template_url.h View 1 chunk +1 line, -1 line 0 comments Download
M components/url_fixer/url_fixer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/url_fixer/url_fixer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/fake_gaia.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/base/registry_controlled_domains/registry_controlled_domain.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/url_util.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/tld_cleanup/tld_cleanup_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/ppb_url_util_shared.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/oauth_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/gurl.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_canon.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_canon_ip.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_canon_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D url/url_parse.h View 1 chunk +0 lines, -11 lines 0 comments Download
M url/url_parse_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/url_parse_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_parse_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_util.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_util_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152373003/1
5 years, 7 months ago (2015-05-25 22:26:54 UTC) #2
tfarina
PTAL.
5 years, 7 months ago (2015-05-25 22:28:15 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-26 04:09:07 UTC) #5
brettw
lgtm
5 years, 7 months ago (2015-05-26 17:13:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152373003/1
5 years, 7 months ago (2015-05-26 17:34:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-26 17:41:28 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 17:42:59 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/018de6ec894a3d4015ca61e2c46dedaf24b1fff5
Cr-Commit-Position: refs/heads/master@{#331390}

Powered by Google App Engine
This is Rietveld 408576698