Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tool/input_sdk/private/isolate_helper.dart

Issue 1152333009: Delete dart2js specific private library code (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tool/input_sdk/private/constant_map.dart ('k') | tool/input_sdk/private/isolate_serialization.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/private/isolate_helper.dart
diff --git a/tool/input_sdk/private/isolate_helper.dart b/tool/input_sdk/private/isolate_helper.dart
index ceac6601b26adca1fbd2b08e7181e0245f63783e..72093f7d7611aa45ecf8930332652bb9ca3ef688 100644
--- a/tool/input_sdk/private/isolate_helper.dart
+++ b/tool/input_sdk/private/isolate_helper.dart
@@ -18,13 +18,11 @@ import 'dart:isolate';
import 'dart:_native_typed_data' show NativeByteBuffer, NativeTypedData;
import 'dart:_js_helper' show
- Closure,
InternalMap,
Null,
Primitives,
convertDartClosureToJS,
- random64,
- requiresPreamble;
+ random64;
import 'dart:_foreign_helper' show DART_CLOSURE_TO_JS,
JS,
@@ -706,7 +704,6 @@ class _MainManagerStub {
//
// See: http://www.w3.org/TR/workers/#the-global-scope
// and: http://www.w3.org/TR/Window/#dfn-self-attribute
- requiresPreamble();
JS("void", r"self.postMessage(#)", msg);
}
}
@@ -715,16 +712,13 @@ const String _SPAWNED_SIGNAL = "spawned";
const String _SPAWN_FAILED_SIGNAL = "spawn failed";
get globalWindow {
- requiresPreamble();
return JS('', "self.window");
}
get globalWorker {
- requiresPreamble();
return JS('', "self.Worker");
}
bool get globalPostMessageDefined {
- requiresPreamble();
return JS('bool', "!!self.postMessage");
}
@@ -908,7 +902,6 @@ class IsolateNatives {
}
static void _consoleLog(msg) {
- requiresPreamble();
JS("void", r"self.console.log(#)", msg);
}
@@ -923,7 +916,7 @@ class IsolateNatives {
* but you should probably not count on this.
*/
static String _getJSFunctionName(Function f) {
- return (f is Closure) ? JS("String|Null", r'#.$name', f) : null;
+ return JS("String|Null", r'#.$name', f);
}
/** Create a new JavaScript object instance given its constructor. */
@@ -1417,7 +1410,6 @@ class TimerImpl implements Timer {
}
bool hasTimer() {
- requiresPreamble();
return JS('', 'self.setTimeout') != null;
}
« no previous file with comments | « tool/input_sdk/private/constant_map.dart ('k') | tool/input_sdk/private/isolate_serialization.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698