Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1152333009: Delete dart2js specific private library code (Closed)

Created:
5 years, 6 months ago by Leaf
Modified:
5 years, 6 months ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Delete dart2js specific private library code. This trims out a large chunk of the more obviously dart2js specific stuff from js_helper.dart and its dependencies. BUG= R=jmesserly@google.com, vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/0d72a073e50ada47ceb02bc22f4fbeaf757d4564

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+753 lines, -10566 lines) Patch
M lib/runtime/dart/_isolate_helper.js View 1 8 chunks +6 lines, -12 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 1 21 chunks +60 lines, -3019 lines 0 comments Download
D lib/runtime/dart/_js_names.js View 1 1 chunk +0 lines, -84 lines 0 comments Download
M lib/runtime/dart/_native_typed_data.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/async.js View 1 3 chunks +3 lines, -4 lines 0 comments Download
M lib/src/dependency_graph.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/html_input.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/sunflower/sunflower.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M tool/input_sdk/patch/async_patch.dart View 2 chunks +1 line, -3 lines 0 comments Download
M tool/input_sdk/private/annotations.dart View 1 2 chunks +0 lines, -14 lines 0 comments Download
D tool/input_sdk/private/constant_map.dart View 1 chunk +0 lines, -147 lines 0 comments Download
M tool/input_sdk/private/isolate_helper.dart View 6 chunks +2 lines, -10 lines 0 comments Download
M tool/input_sdk/private/isolate_serialization.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tool/input_sdk/private/js_helper.dart View 1 15 chunks +9 lines, -2691 lines 0 comments Download
M tool/input_sdk/private/js_mirrors.dart View 1 chunk +11 lines, -3019 lines 0 comments Download
D tool/input_sdk/private/js_names.dart View 1 chunk +0 lines, -115 lines 0 comments Download
M tool/input_sdk/private/js_rti.dart View 2 chunks +5 lines, -666 lines 0 comments Download
M tool/input_sdk/private/mirror_helper.dart View 1 chunk +0 lines, -17 lines 0 comments Download
M tool/input_sdk/private/native_helper.dart View 1 1 chunk +0 lines, -34 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 2 chunks +653 lines, -725 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Leaf
5 years, 6 months ago (2015-06-03 22:37:40 UTC) #2
Jennifer Messerly
lgtm https://codereview.chromium.org/1152333009/diff/1/tool/input_sdk/private/constant_map.dart File tool/input_sdk/private/constant_map.dart (left): https://codereview.chromium.org/1152333009/diff/1/tool/input_sdk/private/constant_map.dart#oldcode7 tool/input_sdk/private/constant_map.dart:7: abstract class ConstantMap<K, V> implements Map<K, V> { ...
5 years, 6 months ago (2015-06-04 16:19:58 UTC) #3
vsm
lgtm
5 years, 6 months ago (2015-06-04 20:09:44 UTC) #4
Leaf
5 years, 6 months ago (2015-06-05 16:52:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0d72a073e50ada47ceb02bc22f4fbeaf757d4564 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698