Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1152333004: Revert of Disable RunsAudioVideoWebRTCCallInTwoTabs so blink can roll (Closed)

Created:
5 years, 7 months ago by phoglund_chromium
Modified:
5 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable RunsAudioVideoWebRTCCallInTwoTabs so blink can roll (patchset #1 id:1 of https://codereview.chromium.org/1148873003/) Reason for revert: Re-enabling after reverting breaking change. BUG=490368 Original issue's description: > Disable RunsAudioVideoWebRTCCallInTwoTabs so blink can roll > > This failure has been preventing blink from rolling for >12 hours. > Sample failure: > > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/66651 > > TBR=cevans@chromium.org,haraken@chromium.org > NOTRY=true > BUG= > > Committed: https://crrev.com/44cafa04c9c11b4ac32c99d39177be62b0a7acd3 > Cr-Commit-Position: refs/heads/master@{#330763} TBR=cevans@chromium.org,haraken@chromium.org,szager@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/692979285996f271ce80aef4677eb56a3b7ed4dd Cr-Commit-Position: refs/heads/master@{#331270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/media/chrome_webrtc_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
phoglund_chromium
Created Revert of Disable RunsAudioVideoWebRTCCallInTwoTabs so blink can roll
5 years, 7 months ago (2015-05-25 09:21:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152333004/1
5 years, 7 months ago (2015-05-25 09:21:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-25 09:22:07 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/692979285996f271ce80aef4677eb56a3b7ed4dd Cr-Commit-Position: refs/heads/master@{#331270}
5 years, 7 months ago (2015-05-25 09:23:17 UTC) #4
haraken
5 years, 7 months ago (2015-05-25 09:31:47 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698