Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1152333002: Fix incorrect ANGLE histogram usage. (Closed)

Created:
5 years, 7 months ago by Jamie Madill
Modified:
5 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, rkaplow
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect ANGLE histogram usage. The enums were incorrectly using the 'units' type. BUG=436191, 477701 Committed: https://crrev.com/0bbd5cbf0ecdedecb89b5667f80582dcbaa0c403 Cr-Commit-Position: refs/heads/master@{#331250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/metrics/histograms/histograms.xml View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jamie Madill
PTAL
5 years, 7 months ago (2015-05-22 20:26:22 UTC) #2
rkaplow
lgtm
5 years, 7 months ago (2015-05-22 20:29:27 UTC) #4
Alexei Svitkine (slow)
lgtm, sorry for not catching this during the original review
5 years, 7 months ago (2015-05-22 20:32:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152333002/1
5 years, 7 months ago (2015-05-24 20:32:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-24 22:04:39 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-24 22:05:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bbd5cbf0ecdedecb89b5667f80582dcbaa0c403
Cr-Commit-Position: refs/heads/master@{#331250}

Powered by Google App Engine
This is Rietveld 408576698