Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 115233006: Classes are showing statics as instance fields/methods (Closed)

Created:
7 years ago by Alan Knight
Modified:
7 years ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dartdoc-viewer.git@master
Visibility:
Public.

Description

Classes are showing statics as instance fields/methods R=efortuna@google.com Committed: https://github.com/dart-lang/dartdoc-viewer/commit/9c28afb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M client/web/class.html View 1 chunk +2 lines, -2 lines 0 comments Download
M client/web/minimap-class.html View 1 chunk +2 lines, -2 lines 0 comments Download
M client/web/search.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
Also, initalized the searchQuery, as I noticed if you went to the search box and ...
7 years ago (2013-12-14 00:56:18 UTC) #1
Emily Fortuna
lgtm
7 years ago (2013-12-14 01:16:21 UTC) #2
Alan Knight
7 years ago (2013-12-14 01:18:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r9c28afb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698