Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Issue 1152323002: Roll src/tools/gyp/ to 29e94a3285ee899d14d5e56a6001682620d3778f. (Closed)

Created:
5 years, 7 months ago by scottmg
Modified:
5 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/tools/gyp/ to 29e94a3285ee899d14d5e56a6001682620d3778f. This reinstates the duplicate basename check, on Mac only. $ git log 0bb67471b..29e94a328 --date=short --format='%ad %ae %s' 2015-05-21 scottmg Avoid lint presubmit error in dump_dependency_json 2015-05-21 scottmg Update shared_library test after c0cf1f22eb 2015-05-21 scottmg Revert "Stop checking for duplicate basenames" 2015-05-14 scottmg Added msvs_application_type_revision for winrt compilation 2015-05-12 torne Remove the Android generator. R=thakis@chromium.org BUG=490824, gyp:384, 472772 Committed: https://crrev.com/013831e64e2ca1414e86fe2498cb193d5a8b8354 Cr-Commit-Position: refs/heads/master@{#331626}

Patch Set 1 #

Patch Set 2 : disable basename check except on Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/gyp_chromium View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (5 generated)
scottmg
5 years, 7 months ago (2015-05-22 20:05:13 UTC) #1
Nico
static library /b/build/slave/linux_chromeos/build/src/ui/base/ime/ui_base_ime.gyp:ui_base_ime#target has several files with the same basename: composition_text: chromeos/composition_text.cc composition_text.cc
5 years, 7 months ago (2015-05-22 20:11:06 UTC) #2
scottmg
On 2015/05/22 20:11:06, Nico wrote: > static library > /b/build/slave/linux_chromeos/build/src/ui/base/ime/ui_base_ime.gyp:ui_base_ime#target > has several files with ...
5 years, 7 months ago (2015-05-22 20:13:03 UTC) #3
scottmg
On 2015/05/22 20:13:03, scottmg wrote: > On 2015/05/22 20:11:06, Nico wrote: > > static library ...
5 years, 7 months ago (2015-05-22 22:17:44 UTC) #4
scottmg
Two more instances removed, I'll tryjob here again now.
5 years, 7 months ago (2015-05-26 16:51:06 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152323002/1
5 years, 7 months ago (2015-05-26 16:51:50 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/80151)
5 years, 7 months ago (2015-05-26 17:01:40 UTC) #9
scottmg
On 2015/05/26 17:01:40, I haz the power - commit-bot wrote: > Dry run: Try jobs ...
5 years, 7 months ago (2015-05-26 17:09:45 UTC) #10
scottmg
Some CrOS folks are non-plussed at having to rename their already long file names (e.g. ...
5 years, 7 months ago (2015-05-27 03:34:11 UTC) #11
Nico
* I think it's generally good if things work the same across platforms. * It's ...
5 years, 7 months ago (2015-05-27 04:33:50 UTC) #12
scottmg
On 2015/05/27 04:33:50, Nico wrote: > * I think it's generally good if things work ...
5 years, 7 months ago (2015-05-27 04:40:57 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152323002/20001
5 years, 7 months ago (2015-05-27 17:42:09 UTC) #15
scottmg
On 2015/05/27 04:40:57, scottmg wrote: > On 2015/05/27 04:33:50, Nico wrote: > > * I ...
5 years, 7 months ago (2015-05-27 17:43:15 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-27 18:58:30 UTC) #18
Nico
lgtm, good comment
5 years, 7 months ago (2015-05-27 19:31:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152323002/20001
5 years, 7 months ago (2015-05-27 19:41:24 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-27 19:46:56 UTC) #22
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 19:47:38 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/013831e64e2ca1414e86fe2498cb193d5a8b8354
Cr-Commit-Position: refs/heads/master@{#331626}

Powered by Google App Engine
This is Rietveld 408576698