|
|
DescriptionRoll src/tools/gyp/ to 29e94a3285ee899d14d5e56a6001682620d3778f.
This reinstates the duplicate basename check, on Mac only.
$ git log 0bb67471b..29e94a328 --date=short --format='%ad %ae %s'
2015-05-21 scottmg Avoid lint presubmit error in dump_dependency_json
2015-05-21 scottmg Update shared_library test after c0cf1f22eb
2015-05-21 scottmg Revert "Stop checking for duplicate basenames"
2015-05-14 scottmg Added msvs_application_type_revision for winrt compilation
2015-05-12 torne Remove the Android generator.
R=thakis@chromium.org
BUG=490824, gyp:384, 472772
Committed: https://crrev.com/013831e64e2ca1414e86fe2498cb193d5a8b8354
Cr-Commit-Position: refs/heads/master@{#331626}
Patch Set 1 #Patch Set 2 : disable basename check except on Mac #Messages
Total messages: 23 (5 generated)
static library /b/build/slave/linux_chromeos/build/src/ui/base/ime/ui_base_ime.gyp:ui_base_ime#target has several files with the same basename: composition_text: chromeos/composition_text.cc composition_text.cc
On 2015/05/22 20:11:06, Nico wrote: > static library > /b/build/slave/linux_chromeos/build/src/ui/base/ime/ui_base_ime.gyp:ui_base_ime#target > has several files with the same basename: > composition_text: chromeos/composition_text.cc composition_text.cc How tremendously thrilling!
On 2015/05/22 20:13:03, scottmg wrote: > On 2015/05/22 20:11:06, Nico wrote: > > static library > > > /b/build/slave/linux_chromeos/build/src/ui/base/ime/ui_base_ime.gyp:ui_base_ime#target > > has several files with the same basename: > > composition_text: chromeos/composition_text.cc composition_text.cc > > How tremendously thrilling! See https://codereview.chromium.org/1149223004
Two more instances removed, I'll tryjob here again now.
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152323002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
On 2015/05/26 17:01:40, I haz the power - commit-bot wrote: > Dry run: Try jobs failed on following builders: > android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) Bother.
Some CrOS folks are non-plussed at having to rename their already long file names (e.g. https://codereview.chromium.org/1148293006/). How do you feel about using --no-duplicate-thingy-whatever-check in build/gyp_chromium on sys.platform != darwin so that it's only enforced where libtool cares?
* I think it's generally good if things work the same across platforms. * It's kind of nice to have something that forces smaller static_libraries. * Eventually, gn's source_sets will make this mostly a moot point everywhere, ruining the previous points. Since it's all moot eventually, might as well go the route of least resistance for now :-( On Tue, May 26, 2015 at 8:34 PM, <scottmg@chromium.org> wrote: > Some CrOS folks are non-plussed at having to rename their already long file > names (e.g. https://codereview.chromium.org/1148293006/). > > How do you feel about using --no-duplicate-thingy-whatever-check in > build/gyp_chromium on sys.platform != darwin so that it's only enforced > where > libtool cares? > > https://codereview.chromium.org/1152323002/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2015/05/27 04:33:50, Nico wrote: > * I think it's generally good if things work the same across platforms. > * It's kind of nice to have something that forces smaller static_libraries. > * Eventually, gn's source_sets will make this mostly a moot point > everywhere, ruining the previous points. > > Since it's all moot eventually, might as well go the route of least > resistance for now :-( Yeah, the first one is the biggest for me, which is why I was changing them instead. I guess I'll just do the disable for now so that gyp can roll again. Oh well. > > On Tue, May 26, 2015 at 8:34 PM, <mailto:scottmg@chromium.org> wrote: > > > Some CrOS folks are non-plussed at having to rename their already long file > > names (e.g. https://codereview.chromium.org/1148293006/). > > > > How do you feel about using --no-duplicate-thingy-whatever-check in > > build/gyp_chromium on sys.platform != darwin so that it's only enforced > > where > > libtool cares? > > > > https://codereview.chromium.org/1152323002/ > > > > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152323002/20001
On 2015/05/27 04:40:57, scottmg wrote: > On 2015/05/27 04:33:50, Nico wrote: > > * I think it's generally good if things work the same across platforms. > > * It's kind of nice to have something that forces smaller static_libraries. > > * Eventually, gn's source_sets will make this mostly a moot point > > everywhere, ruining the previous points. > > > > Since it's all moot eventually, might as well go the route of least > > resistance for now :-( > > Yeah, the first one is the biggest for me, which is why I was changing them > instead. > > I guess I'll just do the disable for now so that gyp can roll again. Oh well. ptal at gyp_chromium > > > > > On Tue, May 26, 2015 at 8:34 PM, <mailto:scottmg@chromium.org> wrote: > > > > > Some CrOS folks are non-plussed at having to rename their already long file > > > names (e.g. https://codereview.chromium.org/1148293006/). > > > > > > How do you feel about using --no-duplicate-thingy-whatever-check in > > > build/gyp_chromium on sys.platform != darwin so that it's only enforced > > > where > > > libtool cares? > > > > > > https://codereview.chromium.org/1152323002/ > > > > > > > To unsubscribe from this group and stop receiving emails from it, send an > email > > to mailto:chromium-reviews+unsubscribe@chromium.org.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, good comment
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152323002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/013831e64e2ca1414e86fe2498cb193d5a8b8354 Cr-Commit-Position: refs/heads/master@{#331626} |