Issue 1152313002: Make SkyView vs. WebView controlable via url path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1152313002: Make SkyView vs. WebView controlable via url path (Closed)

Created:
5 years, 7 months ago by eseidel

Modified:
5 years, 7 months ago

Reviewers:
Hixie

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make SkyView vs. WebView controlable via url path We're currently in a transition between using main.sky and main.dart files as our main() entry point for Sky applications. This CL makes this runtime controlable by path name. If it finds a .dart in the path name it will use SkyView, otherwise it will fall back to the existing WebView codepath. SkyView does not expose a window object and much of the existing Sky Engine is not initialized when main() is run. Clients should be transitioning away from main.sky towards main.dart in the near future, however main.dart is probably not ready for general consumption at this point. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e5d0f6a3ec325d4f9d7d951eaf22e345ad33bf36

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -7 lines)			Patch
M	sky/engine/public/web/WebView.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.cpp	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	sky/viewer/document_view.cc	View	1 chunk	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

5 years, 7 months ago (2015-05-22 19:59:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e5d0f6a3ec325d4f9d7d951eaf22e345ad33bf36 (presubmit successful).

Expand Messages | Collapse Messages