SkPDF: fix name escape code

src/pdf/SkPDFTypes.cpp

Index: src/pdf/SkPDFTypes.cpp
diff --git a/src/pdf/SkPDFTypes.cpp b/src/pdf/SkPDFTypes.cpp
index 2b2921d3fd6b6df144de4464c6dc689ed3b89c4f..68783a32a6871fbfe2fb6d6dfa0383389b23af6e 100644
--- a/src/pdf/SkPDFTypes.cpp
+++ b/src/pdf/SkPDFTypes.cpp
@@ -105,6 +105,9 @@ static SkString escape_name(const char* name, size_t len) {
     int count = 0;
     const char* const end = &name[len];
     for (const char* n = name; n != end; ++n) {
+        if ('\0' == *n) {

[bungeman-skia, 2015/06/08 15:23:48]

If you're doing it this way, you should drop the 'len' parameter completely and
re-write this to use '\0' as the terminator. If you keep 'len' then '\0' should
be escaped. Since 'name' is coming from sources which claim to be utf-8, it's
theoretically more correct to keep 'len' and escape '\0' properly.

[hal.canary, 2015/06/08 15:55:24]

Done.

+            break;  // http://crbug.com/494913
+        }
         if (*n < '!' || *n > '~' || strchr(kToEscape, *n)) {
             count += 2;
         }
@@ -114,6 +117,9 @@ static SkString escape_name(const char* name, size_t len) {
     char* s = result.writable_str();
     static const char kHex[] = "0123456789ABCDEF";
     for (const char* n = name; n != end; ++n) {
+        if ('\0' == *n) {
+            break;
+        }
         if (*n < '!' || *n > '~' || strchr(kToEscape, *n)) {
             *s++ = '#';
             *s++ = kHex[(*n >> 4) & 0xF];