Prepare gpu_channel_host for SharedMemoryHandles not backed by POSIX fds.

Prepare gpu_channel_host for SharedMemoryHandles not backed by POSIX fds.

On Mac, SharedMemoryHandle is soon going to be backed by Mach primtiives. I've
updated the code in GpuChannelHost to reflect this.

BUG=466437
Committed: https://crrev.com/0dcc94c8d2f4b8888756acf63554407d41fb252d
Cr-Commit-Position: refs/heads/master@{#332975}

[erikchen, 2015-06-03 17:49:18]

erikchen@chromium.org changed reviewers:
+ jbauman@chromium.org

[erikchen, 2015-06-03 17:49:19]

jbauman: Please review.

[jbauman, 2015-06-03 22:01:42]

lgtm, with one issue.

https://codereview.chromium.org/1152273005/diff/1/content/common/gpu/client/g...
File content/common/gpu/client/gpu_channel_host.cc (right):

https://codereview.chromium.org/1152273005/diff/1/content/common/gpu/client/g...
content/common/gpu/client/gpu_channel_host.cc:323: return
base::SharedMemory::Duplicatehandle(source_handle);
incorrect capitalization of DuplicateHandle.

[erikchen, 2015-06-03 22:03:01]

https://codereview.chromium.org/1152273005/diff/1/content/common/gpu/client/g...
File content/common/gpu/client/gpu_channel_host.cc (right):

https://codereview.chromium.org/1152273005/diff/1/content/common/gpu/client/g...
content/common/gpu/client/gpu_channel_host.cc:323: return
base::SharedMemory::Duplicatehandle(source_handle);
On 2015/06/03 22:01:41, jbauman wrote:
> incorrect capitalization of DuplicateHandle.

Done.

[erikchen, 2015-06-03 22:03:05]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-06-03 22:03:05]

The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/1152273005/#ps20001
(title: "Capitalization.")

[commit-bot: I haz the power, 2015-06-03 22:04:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1152273005/20001

[commit-bot: I haz the power, 2015-06-03 23:12:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 23:12:10]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2015-06-03 23:18:33]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-06-03 23:19:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1152273005/20001

[commit-bot: I haz the power, 2015-06-04 01:30:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-04 01:30:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2015-06-04 01:54:32]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-06-04 01:54:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1152273005/20001

[commit-bot: I haz the power, 2015-06-04 03:08:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-04 03:08:11]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2015-06-04 17:20:28]

On 2015/06/04 03:08:11, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Note to self:

[2988:3884:0603/195756:FATAL:sandbox_win.cc(488)] Check failed:
!(basic_info.GrantedAccess & WRITE_DAC). You are attempting to duplicate a
privileged handle into a sandboxed process.
 Please use the sandbox::BrokerDuplicateHandle API or contact
security@chromium.org for assistance.

[erikchen, 2015-06-04 19:44:40]

jbauman: I've uploaded a new patch set which reverts to using
BrokerDuplicateHandle() on Windows instead of
BrokerDuplicateSharedMemoryHandle(). This is a regression in terms of semantics,
but retains the original behavior of Windows.

The current interface of BrokerDuplicateSharedMemoryHandle() doesn't support
Windows-specific ACL operations. I'm not sure whether I want to change the
existing interface - this is currently the only location that would need a
change in semantics, so I'm inclined to leave it as is for now.

[jbauman, 2015-06-04 20:48:00]

lgtm

[erikchen, 2015-06-04 23:38:51]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-06-04 23:39:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1152273005/40001

[commit-bot: I haz the power, 2015-06-05 00:38:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-05 00:39:14]

Patchset 3 (id:??) landed as
https://crrev.com/0dcc94c8d2f4b8888756acf63554407d41fb252d
Cr-Commit-Position: refs/heads/master@{#332975}